Skip to content

[PWGLF] Modify K* task for mixed-event v2 extraction in kstarpbpb.cxx#16906

Open
sarjeetagami wants to merge 1 commit into
AliceO2Group:masterfrom
sarjeetagami:master
Open

[PWGLF] Modify K* task for mixed-event v2 extraction in kstarpbpb.cxx#16906
sarjeetagami wants to merge 1 commit into
AliceO2Group:masterfrom
sarjeetagami:master

Conversation

@sarjeetagami

@sarjeetagami sarjeetagami commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwglf label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@sarjeetagami sarjeetagami force-pushed the master branch 2 times, most recently from b199f5b to e3a1847 Compare July 2, 2026 17:12
@vkucera

vkucera commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

@sarjeetagami Please fix the name of you repository. It's blocking the creation of the automatic formatting PR.

@sarjeetagami sarjeetagami force-pushed the master branch 2 times, most recently from ae13af0 to 3df9ba9 Compare July 3, 2026 06:47
@sarjeetagami sarjeetagami changed the title [PWGLF] Modify K* task for mixed-event v2 extraction [PWGLF] Modify K* task for mixed-event v2 extraction in kstarpbpb.cxx Jul 3, 2026
@sarjeetagami sarjeetagami marked this pull request as ready for review July 3, 2026 06:54
@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 3df9ba9 at 2026-07-03 09:23:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarpbpb.cxx:779:12: error: unused variable 'centrality2' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarpbpb.cxx:1009:22: error: variable 'eventplaneVecRec' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarpbpb.cxx:1076:18: error: variable 'eventplaneVecGen' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3df9ba9 at 2026-07-03 09:26:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 7 warnings.'
Found 10 errors and 7 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/63b505c94773b10b723fd241f47150d17472d9c0/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarpbpb.cxx:21:1: error: included header TriggerAliases.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:53:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:68:8: error: constructor does not initialize these fields: ccdb, v2, v2Rot, hweight [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:456:48: error: narrowing conversion from constant 'float' to 'unsigned int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:464:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:779:12: error: Value stored to 'centrality2' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:779:12: error: unused variable 'centrality2' [clang-diagnostic-unused-variable,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:958:15: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:958:30: error: no header providing "PDG_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:1172:15: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/63b505c94773b10b723fd241f47150d17472d9c0/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarpbpb.cxx:493:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:496:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:500:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:504:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:508:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:512:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:1218:59: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 10 -gt 0 ]]
++ exit 1
--

Full log here.

@sarjeetagami sarjeetagami marked this pull request as draft July 3, 2026 08:20
@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 3df9ba9 at 2026-07-03 10:21:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@sarjeetagami sarjeetagami marked this pull request as ready for review July 3, 2026 10:09
@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4b8cf94 at 2026-07-03 14:52:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 0 warnings.'
Found 8 errors and 0 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/85c322bf7ef5ca7309cf7f963b2c5779b0b3507f/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarpbpb.cxx:21:1: error: included header TriggerAliases.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:53:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:68:8: error: constructor does not initialize these fields: ccdb, v2, v2Rot, hweight [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:453:48: error: narrowing conversion from constant 'float' to 'unsigned int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:461:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:954:15: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:954:30: error: no header providing "PDG_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:1166:15: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 8 -gt 0 ]]
++ exit 1
--

Full log here.

prottayCMT
prottayCMT requested changes Jul 3, 2026
View reviewed changes

@prottayCMT prottayCMT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the errors on code-check

@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3549263 at 2026-07-03 19:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/dec05d4fad965e4d90775d34f83a0506f2da25d6/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarpbpb.cxx:21:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@dmallick2 dmallick2 enabled auto-merge (squash) July 3, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prottayCMT prottayCMT prottayCMT requested changes
@dmallick2 dmallick2 dmallick2 approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner
@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sarjeetagami @vkucera @alibuild @prottayCMT @dmallick2