Skip to content

[PWGLF] Apply missing cuts before filling dE/dx vs momentum histograms#16848

Open
PaolaVT wants to merge 36 commits into
AliceO2Group:masterfrom
PaolaVT:master
Open

[PWGLF] Apply missing cuts before filling dE/dx vs momentum histograms#16848
PaolaVT wants to merge 36 commits into
AliceO2Group:masterfrom
PaolaVT:master

Conversation

@PaolaVT

@PaolaVT PaolaVT commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

-multiplicityPt.cxx:
The dE/dx vs. momentum histograms were being filled before the required track selection cuts. The filling order has been corrected so that only tracks passing all cuts contribute to the histograms. As well as, the unused CentClasses member was deleted.

-dedxPidAnalysis.cxx:
The fphiCutLow/fphiCutHigh arguments from passedPhiCutPri and passedPhiCutSecondaries were removed and struct members were used directly instead.

@github-actions github-actions Bot added the pwglf label Jun 28, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Apply missing cuts before filling dE/dx vs momentum histograms [PWGLF] Apply missing cuts before filling dE/dx vs momentum histograms Jun 28, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 4783643 at 2026-06-30 17:29:

No log files found

Full log here.

@alibuild

alibuild commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4783643 at 2026-07-02 00:26:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 65 errors and 53 warnings.'
Found 65 errors and 53 warnings.
++ [[ 65 -gt 0 ]]
++ cat /sw/BUILD/628028d2da62c0d3620dee16b8c0ab82157f3471/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:16:1: error: included header LFParticleIdentification.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:17:1: error: included header mcCentrality.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:18:1: error: included header spectraTOF.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:19:1: error: included header inelGt.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:21:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:26:1: error: included header McCollisionExtra.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:28:1: error: included header PIDResponseTOF.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:34:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:41:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:47:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:50:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:52:1: error: included header numeric is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:53:1: error: included header set is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:86:28: error: no header providing "TH3" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:86:46: error: variable 'hDedxVsMomentumVsCentPos' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:87:46: error: variable 'hDedxVsMomentumVsCentNeg' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:88:50: error: variable 'hDedxVspTMomentumVsCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:89:28: error: no header providing "TH2" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:89:50: error: variable 'hMomentumVsEtaPos' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:90:50: error: variable 'hMomentumVsEtaNeg' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:91:50: error: variable 'hpTVsEtaPos' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:92:50: error: variable 'hpTVsEtaNeg' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:94:50: error: variable 'hTotalMomPosCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:95:50: error: variable 'hTotalMomNegCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:96:50: error: variable 'hTotalPtPosCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:97:50: error: variable 'hTotalPtNegCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:99:74: error: variable 'hFracMomPosCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:100:74: error: variable 'hFracMomNegCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:101:74: error: variable 'hFracPtPosCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:102:74: error: variable 'hFracPtNegCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:104:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:107:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:116:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:186:3: error: no header providing "o2::framework::ConfigurableAxis" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:186:44: error: no header providing "o2::framework::VARIABLE_WIDTH" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:198:46: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:212:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:216:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:216:25: error: no header providing "std::string_view" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:217:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:244:13: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:255:45: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@PaolaVT PaolaVT marked this pull request as draft July 1, 2026 22:58
@maciacco maciacco marked this pull request as ready for review July 2, 2026 11:44
@alibuild

alibuild commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b2d848f at 2026-07-02 14:12:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 96 errors and 171 warnings.'
Found 96 errors and 171 warnings.
++ [[ 96 -gt 0 ]]
++ cat /sw/BUILD/4870b7a64530569c50e86314cd69697ff60b196b/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:69:46: error: variable 'hDedxVsMomentumVsCentPos' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:70:46: error: variable 'hDedxVsMomentumVsCentNeg' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:71:50: error: variable 'hDedxVspTMomentumVsCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:72:28: error: no header providing "TH2" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:72:50: error: variable 'hMomentumVsEtaPos' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:73:50: error: variable 'hMomentumVsEtaNeg' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:74:50: error: variable 'hpTVsEtaPos' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:75:50: error: variable 'hpTVsEtaNeg' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:77:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:259:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:260:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:261:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:262:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:263:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:265:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:266:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:267:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:268:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:270:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:271:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:272:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:273:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:275:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:276:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:277:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:278:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:279:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:280:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:301:42: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:1504:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:1516:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:1528:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:16:1: error: included header LFParticleIdentification.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:17:1: error: included header mcCentrality.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:18:1: error: included header spectraTOF.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:19:1: error: included header inelGt.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:21:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:26:1: error: included header McCollisionExtra.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:28:1: error: included header PIDResponseTOF.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:34:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:41:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:47:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@maciacco maciacco marked this pull request as draft July 2, 2026 12:14
@maciacco maciacco marked this pull request as ready for review July 2, 2026 12:14
@maciacco maciacco marked this pull request as draft July 2, 2026 12:14
@PaolaVT PaolaVT marked this pull request as ready for review July 3, 2026 19:53
@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 2a04ed9 at 2026-07-03 22:25:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 70 errors and 173 warnings.'
Found 70 errors and 173 warnings.
++ [[ 70 -gt 0 ]]
++ cat /sw/BUILD/2fb2ea46a3ab073c6636c1650c37a0ff486af74a/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:54:1: error: included header string_view is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:70:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:287:42: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:1358:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:1370:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/dedxPidAnalysis.cxx:1382:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:16:1: error: included header LFParticleIdentification.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:17:1: error: included header mcCentrality.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:18:1: error: included header spectraTOF.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:19:1: error: included header inelGt.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:21:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:26:1: error: included header McCollisionExtra.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:28:1: error: included header PIDResponseTOF.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:34:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:41:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:47:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:50:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:52:1: error: included header numeric is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:53:1: error: included header set is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:86:28: error: no header providing "TH3" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:86:46: error: variable 'hDedxVsMomentumVsCentPos' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:87:46: error: variable 'hDedxVsMomentumVsCentNeg' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:88:50: error: variable 'hDedxVspTMomentumVsCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:89:28: error: no header providing "TH2" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:89:50: error: variable 'hMomentumVsEtaPos' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:90:50: error: variable 'hMomentumVsEtaNeg' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:91:50: error: variable 'hpTVsEtaPos' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:92:50: error: variable 'hpTVsEtaNeg' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:94:50: error: variable 'hTotalMomPosCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:95:50: error: variable 'hTotalMomNegCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:96:50: error: variable 'hTotalPtPosCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:97:50: error: variable 'hTotalPtNegCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:99:74: error: variable 'hFracMomPosCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:100:74: error: variable 'hFracMomNegCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:101:74: error: variable 'hFracPtPosCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:102:74: error: variable 'hFracPtNegCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:104:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:107:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:116:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:193:3: error: no header providing "o2::framework::ConfigurableAxis" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:193:44: error: no header providing "o2::framework::VARIABLE_WIDTH" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/multiplicityPt.cxx:206:46: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for c71eeb1 at 2026-07-04 00:14:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:829:42: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:835:72: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:837:73: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:839:74: error: 'kIsGoodZvtxFT0vsPV' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:841:71: error: 'kIsVertexITSTPC' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:843:73: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:1094:75: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for c71eeb1 at 2026-07-04 00:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:829:42: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:835:72: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:837:73: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:839:74: error: 'kIsGoodZvtxFT0vsPV' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:841:71: error: 'kIsVertexITSTPC' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:843:73: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:1094:75: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c71eeb1 at 2026-07-04 00:17:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:829:42: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:835:72: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:837:73: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:839:74: error: 'kIsGoodZvtxFT0vsPV' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:841:71: error: 'kIsVertexITSTPC' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:843:73: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/multiplicityPt.cxx:1094:75: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants