[PWGHF] trackIndexSkimCreator: Avoid computing the pVector of bachelor1 in the inner loop#16569
Open
ktf wants to merge 1 commit into
Open
[PWGHF] trackIndexSkimCreator: Avoid computing the pVector of bachelor1 in the inner loop#16569ktf wants to merge 1 commit into
ktf wants to merge 1 commit into
Conversation
|
O2 linter results: ❌ 0 errors, |
vkucera
reviewed
Jun 8, 2026
Comment on lines
+4134
to
+4138
| // bachelor1 momentum is invariant across the inner (bachelor2) loop; | ||
| // pVector() is a dynamic column with no caching (it recomputes | ||
| // sin/cos on every call), so evaluate it once here instead of on | ||
| // every bachelor2 iteration. | ||
| const std::array<float, 3> pVecCharmBachelor1 = trackCharmBachelor1.pVector(); |
Collaborator
There was a problem hiding this comment.
Thanks @ktf . I think the verbose comment is not needed.
vkucera
requested changes
Jun 8, 2026
Comment on lines
+4134
to
+4138
| // bachelor1 momentum is invariant across the inner (bachelor2) loop; | ||
| // pVector() is a dynamic column with no caching (it recomputes | ||
| // sin/cos on every call), so evaluate it once here instead of on | ||
| // every bachelor2 iteration. | ||
| const std::array<float, 3> pVecCharmBachelor1 = trackCharmBachelor1.pVector(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| // bachelor1 momentum is invariant across the inner (bachelor2) loop; | |
| // pVector() is a dynamic column with no caching (it recomputes | |
| // sin/cos on every call), so evaluate it once here instead of on | |
| // every bachelor2 iteration. | |
| const std::array<float, 3> pVecCharmBachelor1 = trackCharmBachelor1.pVector(); | |
| const auto pVecCharmBachelor1 = trackCharmBachelor1.pVector(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.