[PWGHF] Fix missing McCollisions and refactor MC histograms into subdirectories in taskLcToK0sP.cxx#16541
Draft
dongfangqingxin wants to merge 1 commit into
Draft
[PWGHF] Fix missing McCollisions and refactor MC histograms into subdirectories in taskLcToK0sP.cxx#16541dongfangqingxin wants to merge 1 commit into
dongfangqingxin wants to merge 1 commit into
Conversation
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Error while checking build/O2Physics/o2 for 4ac3499 at 2026-06-05 18:09: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 4ac3499 at 2026-06-05 18:13: Full log here. |
vkucera
requested changes
Jun 5, 2026
| constexpr static std::string_view SignalFolders[] = {"signal", "prompt", "nonprompt"}; | ||
| constexpr static std::string_view SignalSuffixes[] = {"", "Prompt", "NonPrompt"}; | ||
|
|
||
| enum SignalClasses : int { |
Collaborator
There was a problem hiding this comment.
Suggested change
| enum SignalClasses : int { | |
| enum SignalClass : int { |
| @@ -460,6 +575,16 @@ struct HfTaskLcToK0sP { | |||
| if (std::abs(candidate.flagMcMatchRec()) == KDecayChannelLcToK0sP) { | |||
Collaborator
There was a problem hiding this comment.
This is wrong. Compare against the actual filled constant.
Contributor
Author
There was a problem hiding this comment.
This is wrong. Compare against the actual filled constant.
Hi @vkucera, since there's no Λc+ → pK0s decay channel defined in PWGHF/Core/DecayChannels.h, so I defined one locally ('KDecayChannelLcToK0sP = 1') in the task, following what's done in taskCharmPolarisation.cxx. What should I do in this case?
| template <int SignalType, typename CandidateType> | ||
| void fillHistogramsRecSig(CandidateType const& candidate) | ||
| { | ||
| auto v = extractCandVars(candidate); |
| } | ||
| } else { | ||
| // MC reconstructed background | ||
| auto v = extractCandVars(candidate); |
Comment on lines
+326
to
+335
| float ptCand, eta, phi, invMassLcToK0sP; | ||
| float ptProng0, ptProng1; | ||
| float impactParameter0, impactParameter1; | ||
| float dcaPosToPV, dcaNegToPV; | ||
| float ptV0Pos, ptV0Neg; | ||
| float v0CosPA, v0Radius, dcaV0Daughters; | ||
| float mK0Short, mLambda, mAntiLambda, mGamma; | ||
| float ctV0K0Short, ctV0Lambda; | ||
| float cpa, cpaXY; | ||
| float decayLength, decayLengthXY, ctLc; |
Collaborator
There was a problem hiding this comment.
You must initialise all members.
Comment on lines
+338
to
+340
| template <typename CandType> | ||
| CandVars extractCandVars(CandType const& candidate) | ||
| { |
Collaborator
There was a problem hiding this comment.
This is a conversion constructor.
Collaborator
|
@dongfangqingxin Did you check for warnings in your compilation? |
Contributor
Author
Hi @vkucera Thanks for the comments! I used a script that only catches errors, not warnings and I did not check log manually — my bad. I'm going to drop the extractCandVars template and just repeat the code instead. |
Collaborator
Why do you want to drop it? |
Contributor
Author
Since both alibuild and the O2 linter were complaining about the template I and figured removing it was the quickest fix |
…l/prompt/nonprompt/background subdirectories - Add missing McCollisions dependency - Reorganise MC/Rec and MC/Gen histograms into signal/prompt/nonprompt/background subdirectories - Code clean up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taskLcToK0sP.cxx was Updated in this PR