[PWGLF] ptmultCorr.cxx: Add DCA_xy axis in MC reco for secondary contamination estimation#16540
Open
akyadav1963 wants to merge 3 commits into
Open
[PWGLF] ptmultCorr.cxx: Add DCA_xy axis in MC reco for secondary contamination estimation#16540akyadav1963 wants to merge 3 commits into
akyadav1963 wants to merge 3 commits into
Conversation
|
O2 linter results: ❌ 0 errors, |
akyadav1963
added a commit
to akyadav1963/O2Physics
that referenced
this pull request
Jun 5, 2026
Please consider the following formatting changes to AliceO2Group#16540
Collaborator
|
Error while checking build/O2Physics/o2 for 2e3e0d8 at 2026-06-05 14:20: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 2e3e0d8 at 2026-06-05 14:20: Full log here. |
Collaborator
|
@akyadav1963 You are supposed to test your changes before you open a PR. |
…tamination estimation
2e3e0d8 to
737b761
Compare
Contributor
Author
|
@vkucera I am Sorry for the oversight. The issue was due to a missing TPDGCode.h include, which caused the PDG_t symbols to be undefined during compilation. I have added the missing header, verified that the task builds successfully locally, and updated the PR. |
Collaborator
Did you also run the code and validate the output? |
vkucera
reviewed
Jun 5, 2026
Comment on lines
+196
to
+198
| Configurable<bool> isApplyDCACuts{"isApplyDCACuts", false, "Enable DCA cuts (set to false for secondary estimation)"}; | ||
| Configurable<bool> isApplyITSCuts{"isApplyITSCuts", false, "Enable ITS cuts (set to false for secondary estimation)"}; | ||
| Configurable<bool> isApplyChi2Cuts{"isApplyChi2Cuts", false, "Enable χ² cuts (set to false for secondary estimation)"}; |
Collaborator
There was a problem hiding this comment.
isApply does not make sense.
Suggested change
| Configurable<bool> isApplyDCACuts{"isApplyDCACuts", false, "Enable DCA cuts (set to false for secondary estimation)"}; | |
| Configurable<bool> isApplyITSCuts{"isApplyITSCuts", false, "Enable ITS cuts (set to false for secondary estimation)"}; | |
| Configurable<bool> isApplyChi2Cuts{"isApplyChi2Cuts", false, "Enable χ² cuts (set to false for secondary estimation)"}; | |
| Configurable<bool> applyDCACuts{"applyDCACuts", false, "Enable DCA cuts (set to false for secondary estimation)"}; | |
| Configurable<bool> applyITSCuts{"applyITSCuts", false, "Enable ITS cuts (set to false for secondary estimation)"}; | |
| Configurable<bool> applyChi2Cuts{"applyChi2Cuts", false, "Enable χ² cuts (set to false for secondary estimation)"}; |
Collaborator
There was a problem hiding this comment.
- Don't mark suggestions as resolved.
- You did not apply the change properly.
Contributor
Author
@vkucera yes I did. |
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.