Skip to content

[PWGLF] MC matching for kinkBuilder + SP process function for L1405#16484

Open
Marcellocosti wants to merge 12 commits into
AliceO2Group:masterfrom
Marcellocosti:master
Open

[PWGLF] MC matching for kinkBuilder + SP process function for L1405#16484
Marcellocosti wants to merge 12 commits into
AliceO2Group:masterfrom
Marcellocosti:master

Conversation

@Marcellocosti
Copy link
Copy Markdown
Contributor

@Marcellocosti Marcellocosti commented Jun 1, 2026 •
edited
Loading

  • kinkBuilder: added process function with Monte Carlo matching, histograms to study reconstruction efficiency, selection QA histograms and process function to analyze specific centrality intervals
  • lambda1405analysis: added process function with Scalar Product information, histograms for efficiency evaluation, possibility to analyze only a selected centrality class + QA histograms

Tagging @fmazzasc, @stefanopolitano

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026 •
edited
Loading

O2 linter results: ❌ 9 errors, ⚠️ 11 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Jun 1, 2026
Merged
Marcellocosti added a commit to Marcellocosti/O2Physics that referenced this pull request Jun 1, 2026
@Marcellocosti
Merge pull request #71 from alibuild/alibot-cleanup-16484
51bed22 
[PWGLF] Please consider the following formatting changes to AliceO2Group#16484
@alibuild alibuild mentioned this pull request Jun 2, 2026
Merged
@Marcellocosti Marcellocosti marked this pull request as ready for review June 2, 2026 04:27
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Jun 2, 2026

Error while checking build/O2Physics/staging for 0ca9223 at 2026-06-02 08:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:831:43: error: unused parameter 'mcGenCollisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:842:48: error: unused parameter 'mcGenCollisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Jun 2, 2026

Error while checking build/O2Physics/o2 for 0ca9223 at 2026-06-02 09:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:831:43: error: unused parameter 'mcGenCollisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:842:48: error: unused parameter 'mcGenCollisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Jun 2, 2026
View reviewed changes
Comment thread PWGLF/Tasks/Resonances/lambda1405analysis.cxx Outdated
vkucera
vkucera reviewed Jun 2, 2026
View reviewed changes
Comment thread PWGLF/Tasks/Resonances/lambda1405analysis.cxx Outdated
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Jun 2, 2026

You are adding plenty of magic numbers. Don't.

@vkucera vkucera marked this pull request as draft June 2, 2026 14:24
@alibuild alibuild mentioned this pull request Jun 3, 2026
Merged
@Marcellocosti
Copy link
Copy Markdown
Contributor Author

Marcellocosti commented Jun 3, 2026

Thanks for your review @vkucera, I implemented your comments and fixed most of the warnings, which were although already present in the code

@Marcellocosti Marcellocosti marked this pull request as ready for review June 3, 2026 10:32
vkucera
vkucera reviewed Jun 3, 2026
View reviewed changes
Comment thread PWGLF/TableProducer/Common/kinkBuilder.cxx Outdated
Comment on lines +68 to +71
enum KinkDecayType { kSigmaMinusToPiMinusNeutron = 0,
kSigmaPlusToPiPlusNeutron,
kSigmaPlusToProtonPi0,
kNMatchedDecays };
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are compile-time constants. Don't use the k prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner

@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner

@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Marcellocosti @alibuild @vkucera