[PWGHF] [xic0omegac0] Update codes to fix PID assignment in KFParticle#16381
[PWGHF] [xic0omegac0] Update codes to fix PID assignment in KFParticle#16381jinhyunni wants to merge 8 commits into
Conversation
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#16381
|
@jinhyunni Thanks for spotting and fixing this issue! The PR is fine for me, however I think you can solve the same issue in a cleaner way if you define a helper function that converts the PDG code to the correct o2::track::PID one, as Fernanda did in #16352 . |
|
Hi @fcatalan92, thank you for reviewing this PR and for sharing your thoughts on this point. I agree that introducing a helper function would make the implementation cleaner. My initial intention was to keep these assignments together with the other decay-channel-dependent variables in the That said, if you think the helper-function approach would be better for maintainability or consistency with the existing code style, I would be happy to update the implementation accordingly. |
Hi @jinhyunni, yes, if you have time, it would be great if you could update the PR using the helper-function approach. Thanks! |
This PR aims to fix PID assignment when using
getTrackParCovFromKFP()method incandidateCreatorXic0Omegac0Qa.cxxcode.@fcatalan92, @mtorresc15