Skip to content

DPL: move TPDGDatabase customization to plugin#9983

Merged
ktf merged 3 commits into
AliceO2Group:devfrom
ktf:pdg-plugin
Oct 7, 2022
Merged

DPL: move TPDGDatabase customization to plugin#9983
ktf merged 3 commits into
AliceO2Group:devfrom
ktf:pdg-plugin

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Oct 3, 2022

This will avoid that every single device links against libPhysics & co.

@ktf ktf requested a review from a team as a code owner October 3, 2022 18:16
@ktf
Copy link
Copy Markdown
Member Author

ktf commented Oct 3, 2022

@sawenzel @aalkin could you cross check this behaves as expected?

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Oct 3, 2022

Error while checking build/O2/o2 for 3c86edd at 2022-10-03 20:46:

## sw/BUILD/O2-latest/log
[ERROR] Could not load library O2FrameworkPhysicsSupport
[ERROR] libO2FrameworkPhysicsSupport.so: cannot open shared object file: No such file or directory
100% tests passed, 0 tests failed out of 457
 86/106 Test #100: test_Framework_test_SimpleDataProcessingDevice01 ........***Failed    2.15 sec
[ERROR] pid 27247 (internal-dpl-injected-dummy-sink) crashed with 1
[ERROR] SEVERE: Device internal-dpl-injected-dummy-sink (27247) returned with 1
99% tests passed, 1 tests failed out of 102

Full log here.

@ktf
DPL: move TPDGDatabase customization to plugin
207833a 
This will avoid that every single device links against libEG &
co.
Notice how we need to build the plugin before the workflows,
to avoid it is not found at runtime.
@ktf ktf requested a review from a team as a code owner October 3, 2022 19:32
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Oct 3, 2022 •
edited
Loading

Error while checking build/O2/o2 for 207833a at 2022-10-04 18:21:

## sw/BUILD/O2-latest/log
100% tests passed, 0 tests failed out of 457
100% tests passed, 0 tests failed out of 102


## sw/BUILD/O2Physics-latest/log
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Oct 4, 2022 •
edited
Loading

Error while checking build/O2/o2-cs8 for 207833a at 2022-10-04 10:52:

## sw/BUILD/O2-latest/log
100% tests passed, 0 tests failed out of 457
100% tests passed, 0 tests failed out of 102


## sw/BUILD/O2Physics-latest/log
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Oct 4, 2022

Error while checking build/O2/o2-dataflow for 207833a at 2022-10-04 07:35:

## sw/BUILD/O2-latest/log
100% tests passed, 0 tests failed out of 434
 84/106 Test  #98: test_Framework_test_ParallelProducer ....................***Failed    2.47 sec
[ERROR] pid 25408 (merger) crashed with 1
[ERROR] SEVERE: Device merger (25408) returned with 1
99% tests passed, 1 tests failed out of 102

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Oct 4, 2022 •
edited
Loading

Error while checking build/O2/fullCI for 207833a at 2022-10-06 02:01:

No log files found

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Oct 6, 2022 •
edited
Loading

Error while checking build/AliceO2/O2/o2/macOS for 359f9be at 2022-10-06 14:36:

No log files found

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Oct 6, 2022

Error while checking build/O2/o2 for 359f9be at 2022-10-06 14:36:

No log files found

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Oct 6, 2022

Error while checking build/O2/fullCI for 359f9be at 2022-10-06 14:49:

No log files found

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Oct 6, 2022

Error while checking build/O2/o2-cs8 for 359f9be at 2022-10-06 20:58:

## sw/BUILD/O2-latest/log
100% tests passed, 0 tests failed out of 457
100% tests passed, 0 tests failed out of 102


## sw/BUILD/QualityControl-latest/log
100% tests passed, 0 tests failed out of 38


## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@ktf
Copy link
Copy Markdown
Member Author

ktf commented Oct 7, 2022

Tests already fully passed, trivial conflict fix triggered rebuild. Tested again on hyperloop and everything seems fine. Merging.

@ktf ktf merged commit 853cf30 into AliceO2Group:dev Oct 7, 2022
@ktf ktf deleted the pdg-plugin branch October 7, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ktf @alibuild