TRD raw reader update#9776
Merged
Merged
Conversation
martenole
commented
Sep 7, 2022
Collaborator
|
Error while checking build/O2/o2-dataflow for 9e1ce89 at 2022-09-07 21:59: Full log here. |
- Fix some minor compiler warnings - Improve error message handling - Fix option to parse only calibration triggers
bazinski
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Won't pass the CI until the CCDB object
TRD/Config/LinkToHCIDMappingis available. But when it is we can enable link to HCID mapping from CCDB.In addition some warnings have been replaced by sending error counters to QC. And currently the CRU sends quite often bogus link data which would always lead to warnings in the log file. Therefore the warnings are disabled for now and should be re-enabled when the CRU is updated. We still send errors counters for this to QC.
Finally, some more compiler warnings are addressed.