Skip to content

[Event Display] Adds primary vertex selection based on its position - #9659

Merged
shahor02 merged 2 commits into
AliceO2Group:devfrom
maoderos:VertexPositionFilter
Sep 3, 2022
Merged

[Event Display] Adds primary vertex selection based on its position#9659
shahor02 merged 2 commits into
AliceO2Group:devfrom
maoderos:VertexPositionFilter

Conversation

@maoderos

@maoderos maoderos commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

This PR adds x,y,z range parameters for selecting primary vertices in primary vertex mode based on its position. Jira ticket ED-90.

davidrohr
davidrohr approved these changes Aug 23, 2022
View reviewed changes

@davidrohr davidrohr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving such that the CI runs

@rpezzi rpezzi mentioned this pull request Aug 31, 2022
Closed
@alibuild

alibuild commented Aug 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/o2 for 11b58c4 at 2022-09-03 17:36:

## sw/BUILD/O2-latest/log
443/446 Test #402: o2sim_hepmc ..........................................................................***Timeout 400.01 sec
99% tests passed, 1 tests failed out of 446
100% tests passed, 0 tests failed out of 101

Full log here.

@alibuild

alibuild commented Sep 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/o2-cs8 for 11b58c4 at 2022-09-03 19:46:

## sw/BUILD/O2-latest/log
100% tests passed, 0 tests failed out of 446
100% tests passed, 0 tests failed out of 101


## sw/BUILD/QualityControl-latest/log
 1/42 Test  #1: testDbFactory ...........................***Timeout  30.04 sec
 6/42 Test  #6: testTaskInterface .......................***Timeout  30.04 sec
16/42 Test #16: testCcdbDatabase ........................***Timeout  60.05 sec
17/42 Test #18: testTriggers ............................***Timeout  30.02 sec
18/42 Test #19: testTriggerHelpers ......................***Timeout  30.03 sec
2022-09-03 17:40:38.832318 !!! �[1;31mError - Unexpected format of string describing time 'sec'�[0m
2022-09-03 17:40:38.832464 !!! �[1;31mError - Unexpected format of string describing time 'asec'�[0m
23/42 Test #25: testCheckWorkflow .......................***Timeout  50.12 sec
[2755:qc-task-TST-XYZTask]: 2022-09-03 17:41:15.842398 !!! �[1;31mError - Could not find the DPL InfoLogger�[0m
[2756:qc-task-TST-newName]: 2022-09-03 17:41:15.848133 !!! �[1;31mError - Could not find the DPL InfoLogger�[0m
[2757:qc-check-sink-QTST_QYZTask_0]: 2022-09-03 17:41:15.955497 !!! �[1;31mError - Could not find the DPL InfoLogger.�[0m
[2754:qc-task-TST-QYZTask]: 2022-09-03 17:41:16.008995 !!! �[1;31mError - Could not find the DPL InfoLogger�[0m
[2759:qc-check-TST-u2F0]: 2022-09-03 17:41:16.106501 !!! �[1;31mError - Could not find the DPL InfoLogger.�[0m
[2761:qc-check-TST-XYZCheck]: 2022-09-03 17:41:16.106502 !!! �[1;31mError - Could not find the DPL InfoLogger.�[0m
[2758:qc-check-sink-QTST_XYZTask_0]: 2022-09-03 17:41:16.191243 !!! �[1;31mError - Could not find the DPL InfoLogger.�[0m
[2760:qc-check-TST-CheckSeparately]: 2022-09-03 17:41:16.178646 !!! �[1;31mError - Could not find the DPL InfoLogger.�[0m
24/42 Test #26: testWorkflow ............................***Timeout  40.05 sec
2022-09-03 17:42:03.445245 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3156:qc-task-TST-skeletonTask]: 2022-09-03 17:42:05.706330 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3155:Dispatcher]: 2022-09-03 17:42:05.706451 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3156:qc-task-TST-skeletonTask]: 2022-09-03 17:42:05.725585 !!! �[1;31mError - Could not find the DPL InfoLogger�[0m
[3153:internal-dpl-clock]: 2022-09-03 17:42:05.728891 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3157:qc-check-TST-QcCheck]: 2022-09-03 17:42:05.729944 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3158:receiver]: 2022-09-03 17:42:05.733889 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3154:producer]: 2022-09-03 17:42:05.735574 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3157:qc-check-TST-QcCheck]: 2022-09-03 17:42:05.747714 !!! �[1;31mError - Could not find the DPL InfoLogger.�[0m
29/42 Test #31: testUserCodeInterface ...................***Timeout  30.02 sec
[ERROR] Requested resource does not exist: ccdb-test.cern.ch:8080/qc/TST/MO/Test/pid3401/asdf/1662226994298/
/sw/SOURCES/QualityControl/v1.72.0/v1.72.0/Framework/test/testUserCodeInterface.cxx(96): �[1;31;49merror: in "test_invoke_all_methods": check obj != nullptr has failed [0 == nullptr]�[0;39;49m
30/42 Test #32: functional_test .........................***Timeout  45.03 sec
[3477:qc-task-TST-FunctionalTestLeVn7]: 2022-09-03 17:43:35.415370 !!! �[1;31mError - Could not find the DPL InfoLogger�[0m
[3478:qc-check-TST-FunctionalTestLeVn7]: 2022-09-03 17:43:35.396603 !!! �[1;31mError - Could not find the DPL InfoLogger.�[0m
31/42 Test #33: multinode_test ..........................***Timeout  75.00 sec
2022-09-03 17:44:16.508408 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
2022-09-03 17:44:16.509291 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3734:qc-check-TST-MultiNodeLocalTest]: 2022-09-03 17:44:19.251241 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3736:internal-dpl-injected-dummy-sink]: 2022-09-03 17:44:19.296800 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3732:TST-MERGER-MultiNodeLocalTest391041l-0]: 2022-09-03 17:44:19.324194 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3729:internal-dpl-clock]: 2022-09-03 17:44:19.337246 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3733:qc-task-TST-MultiNodeRemoteTest31445]: 2022-09-03 17:44:19.335097 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3731:sampling2]: 2022-09-03 17:44:19.370497 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3734:qc-check-TST-MultiNodeLocalTest]: 2022-09-03 17:44:19.370860 !!! �[1;31mError - Could not find the DPL InfoLogger.�[0m
[3744:Dispatcher]: 2022-09-03 17:44:19.349773 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m
[3735:qc-check-TST-MultiNodeRemoteTest]: 2022-09-03 17:44:19.366599 !!! �[1;31mError - Cycle duration is too short (5), replaced by a duration of 10 seconds.�[0m

Full log here.

@shahor02
shahor02 merged commit 5f3c03d into AliceO2Group:dev Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidrohr davidrohr davidrohr approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maoderos @alibuild @davidrohr @shahor02