Skip to content

MatchGlobalFwd fix: do not throw on empty bunch filling (unused) #9383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Jul 9, 2022
Merged

MatchGlobalFwd fix: do not throw on empty bunch filling (unused) #9383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Detectors/GlobalTracking/src/MatchGlobalFwd.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,8 @@ void MatchGlobalFwd::setBunchFilling(const o2::BunchFilling& bf)
// find closest (from above) filled bunch
int minBC = bf.getFirstFilledBC(), maxBC = bf.getLastFilledBC();
if (minBC < 0) {
throw std::runtime_error("Bunch filling is not set in MatchGlobalFwd");
LOG(error) << "Empty bunch filling is provided to MatchGlobalFwd, checks using it should be ignored";
return;
}
int bcAbove = minBC;
for (int i = o2::constants::lhc::LHCMaxBunches; i--;) {
Expand Down Expand Up @@ -751,9 +752,9 @@ o2::dataformats::GlobalFwdTrack MatchGlobalFwd::MCHtoFwd(const o2::mch::TrackPar
//_________________________________________________________________________________________________
MatchGlobalFwd::MatchGlobalFwd()
{
mClosestBunchAbove[0] = mClosestBunchAbove[0] = -1;

// Define built-in matching functions

//________________________________________________________________________________
mMatchingFunctionMap["matchALL"] = [](const GlobalFwdTrack& mchTrack, const TrackParCovFwd& mftTrack) -> double {
// Match two tracks evaluating all parameters: X,Y, phi, tanl & q/pt
Expand Down