Its-gpu: add tracklet finding and cell finding on GPU (HIP+NVIDIA) - #9289
Merged
Conversation
mconcas
force-pushed
the
its-gpu-tracking
branch
4 times, most recently
from
July 8, 2022 20:18
123d619 to
b38dd07
Compare
mconcas
marked this pull request as ready for review
July 8, 2022 20:20
mconcas
requested review from
bovulpes,
davidrohr,
iouribelikov,
rpezzi and
shahor02
as code owners
July 8, 2022 20:20
Collaborator
Author
|
@davidrohr: this is finally ready for review |
Collaborator
|
ok, will have a look, but I'll postpone merging until after the EPN SW update on Wednesday, in order not to pull in more large changes. |
Collaborator
Author
mconcas
force-pushed
the
its-gpu-tracking
branch
from
July 10, 2022 17:17
165d8d5 to
eb0209d
Compare
mconcas
force-pushed
the
its-gpu-tracking
branch
5 times, most recently
from
July 17, 2022 17:57
0a0e3b9 to
4e61bc8
Compare
Collaborator
Author
|
Hi @TimoWilken, some tests seem not to have no space left on device, just for your knowledge. |
mconcas
force-pushed
the
its-gpu-tracking
branch
2 times, most recently
from
July 23, 2022 13:59
3e508e0 to
118536f
Compare
Collaborator
|
@mconcas : I merged the other PR. Could you rebase this one again :) |
Collaborator
Author
thanks, yep I'm doing it |
Remove plugin for CPU to GPU
mconcas
force-pushed
the
its-gpu-tracking
branch
from
July 28, 2022 15:50
dc77e2c to
f07cc5b
Compare
Collaborator
Author
|
@davidrohr ok, this has been rebased. It can be merged upon green CI. CC-ing @mpuccio |
Collaborator
|
Compiles and runs fine with me, will merge later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do before merging:
[ERROR] Exception caught: std::bad_alloc: hipErrorOutOfMemory: hipErrorOutOfMemoryerror running on HIPthrust::unique()call in hip -> does not occur on MI50