[EMCAL-556] minor improvements in EMCAL DCS DP processing - #8941
Merged
Conversation
mpoghos
commented
May 23, 2022
Contributor
- possibility for using the run number from EMC DCS or from GRP as a trigger for storing the FEE config at SOR
- store the run number in FeeDCS
- minor fixes
mfasDa
reviewed
May 24, 2022
mfasDa
left a comment
Collaborator
There was a problem hiding this comment.
Interface change TriggerDCS/FeeDCS in o2::EMCAL::CalibDB to revised.
Comment on lines
-264
to
+265
| void storeTriggerDCSData(TriggerDCS* dcs, const std::map<std::string, std::string>& metadata, ULong_t timestart, ULong_t timeend); | ||
| void storeFeeDCSData(FeeDCS* dcs, const std::map<std::string, std::string>& metadata, ULong_t timestart, ULong_t timeend); |
Collaborator
There was a problem hiding this comment.
What will happen with the trigger DCS DP? I would guess at some point they will have to be added back. Would have been easier in this case to add new functions for the FeeDCS besides the existing ones for the trigger DCS, in case they are anyhow needed both. This interface change makes the macro tests crashing (since in O2 macros are tested at least for whether they compile).
Contributor
Author
There was a problem hiding this comment.
TriggerDCS is included in FeeDCS
TriggerDCS is included in FeeDCS. no need for a special check
TriggerDCS is included in FeeDCS. no need for a special check
for triggering pr
Collaborator
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.