Skip to content

CTFReader: do not use usleep #8923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
May 22, 2022
Merged

CTFReader: do not use usleep #8923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Detectors/CTF/workflow/src/CTFReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include "Framework/ControlService.h"
#include "Framework/ConfigParamRegistry.h"
#include "Framework/InputSpec.h"
#include "Framework/RawDeviceService.h"
#include "CommonUtils/StringUtils.h"
#include "CommonUtils/FileFetcher.h"
#include "CTFWorkflow/CTFReaderSpec.h"
Expand Down Expand Up @@ -176,7 +177,7 @@ void CTFReaderSpec::run(ProcessingContext& pc)

if (!mCTFCounter) { // RS FIXME: this is a temporary hack to avoid late-starting devices to lose the input
LOG(warning) << "This is a hack, sleeping 5 s at startup";
usleep(1000000);
pc.services().get<RawDeviceService>().waitFor(1000);
}

std::string tfFileName;
Expand Down Expand Up @@ -206,7 +207,7 @@ void CTFReaderSpec::run(ProcessingContext& pc)
mRunning = false;
break;
}
usleep(5000); // wait 5ms for the files cache to be filled
pc.services().get<RawDeviceService>().waitFor(5);
continue;
}
LOG(info) << "Reading CTF input " << ' ' << tfFileName;
Expand Down Expand Up @@ -285,7 +286,7 @@ void CTFReaderSpec::processTF(ProcessingContext& pc)
auto tDiff = tNow - mLastSendTime;
if (mCTFCounter) {
if (tDiff < mInput.delay_us) {
usleep(mInput.delay_us - tDiff); // respect requested delay before sending
pc.services().get<RawDeviceService>().waitFor((mInput.delay_us - tDiff) / 1000); // respect requested delay before sending
}
} else {
mLastSendTime = tNow;
Expand Down