Adding DataDescriptionMatcher operation 'Not'#8565
Merged
Conversation
Collaborator
Author
|
This will disentangle #8561 from the mapping of DataMatcher to ConcreteDataMatchers as we do not need to use the xor operation. On the other hand, introducing the 'Not'-operator might have a similar effect on the handling of concrete data descriptions. |
matthiasrichter
commented
Apr 13, 2022
Collaborator
Author
There was a problem hiding this comment.
@ktf shouldn't we return leftValue here?
matthiasrichter
commented
Apr 13, 2022
Collaborator
Author
There was a problem hiding this comment.
think the correct logic is to return leftValue
Need to check if using this negator operation can have implications on the handling of concrete data types. No impact to existing code however.
b9e9741 to
f6112e2
Compare
matthiasrichter
commented
Apr 14, 2022
|
|
||
| if (mOp == Op::Just) { | ||
| return true; | ||
| return leftValue; |
Collaborator
Author
There was a problem hiding this comment.
I think when having two matchers with just left condition, the two should should be tested for equality and thus we need to return leftValue.
Actually, leftResult and rightresult would be better naming, shall we apply this?
Collaborator
Author
|
moving on with this and merging, the CI error is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to check if using this negator operation can have implications
on the handling of concrete data types. No impact to existing code
however.