[QC-310] Dump a property qcConfiguration for the QC devices - #7942
Merged
Barthelemy merged 7 commits intoJan 18, 2022
Conversation
Introduce a new label `qc-reconfigurable`. Dump a property in the qc tasks pointing to the file in consul to reconfigure the tasks.
Collaborator
Author
|
As discussed, the string manipulation is not nice. |
ktf
previously approved these changes
Jan 14, 2022
ktf
left a comment
Member
There was a problem hiding this comment.
Please fix the code checker stuff, otherwise I have no objections.
Collaborator
Author
|
I'd like Piotr to review as well before we merge. |
knopers8
reviewed
Jan 17, 2022
knopers8
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, I am fine with how it is now, but please consider my two comments.
ktf
self-requested a review
January 17, 2022 08:00
ktf
previously approved these changes
Jan 17, 2022
Collaborator
Author
|
Thank you for your comments. I prefer to apply them to this PR and will do so now. |
Barthelemy
enabled auto-merge (squash)
January 17, 2022 08:57
knopers8
previously approved these changes
Jan 17, 2022
Collaborator
Author
|
@TimoWilken Could you explain what is the error with clang-format ? |
Please consider the following formatting changes to AliceO2Group#7942
Collaborator
Author
|
@TimoWilken undestood |
knopers8
approved these changes
Jan 17, 2022
ktf
self-requested a review
January 18, 2022 08:00
ktf
approved these changes
Jan 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new label
qc-reconfigurable.Dump a property in the qc tasks pointing to the file in consul to reconfigure the tasks.