Implementation of parsing of LHC-IF file - #7148
Conversation
|
Hello @shahor02 , This is the workflow to process the LHC IF file. There is one open point: the dcs-config-proxy expects that the name of the file starts with the three letters of the detector, but we don't have GRP yet. Should it be added? For the development I used "TOF", but it is clearly wrong. This was tested simulating the DCS server sending the file, as we did long ago when developing the dcs-config-proxy. Chiara |
Parser Workflow and data type space checker clang-format remove file added by mistake
13d41b5 to
0faa89d
Compare
Hi @chiarazampolli Expanding DetID will create a mess in many places, we better patch the |
ae6d407 to
087795d
Compare
|
Hi @shahor02 , Thanks for the comment and suggestion, I implemented GRP as an exception. Chiara |
|
Hello @shahor02 , @ktf , @TimoWilken The error in the CI is unrelated to this PR, I don't know why it appears. The same happened on this same PR the other day, but with a different error (then it changed because I added a commit). Chiara |
|
It is due to my bug which is already fixed |
|
I restarted the test. |
|
Thanks! |
remove logging clang-format changing schema --> scheme
087795d to
db4a901
Compare
clang-format leftover fixed
b2fd040 to
89e3fe0
Compare
shahor02
left a comment
There was a problem hiding this comment.
Please see more comments below.
For the time: we use everywhere long, better to stick to it rather than uint64_t, to avoid later warnings about signed/unsigned comparison.
|
Chiara |
Parser
Workflow and data type
space checker
clang-format