[QC-627] Mergers: add postDeserialization() callback and prioritize MergeInterface#6811
Merged
Merged
Conversation
…face This lets the children of MergeInterface to perform any cleanups after ROOT deserializes the object. The main use-case is setting the valid ownership, which cannot be propely set while serializing it for any reason. We also prioritize MergeInterface over TObject when a class inherits both.
Barthelemy
approved these changes
Aug 9, 2021
Collaborator
|
the macOS failure is not related, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets the children of MergeInterface to perform any cleanups after ROOT deserializes the object. The main use-case is setting the valid ownership, which cannot be propely set while serializing it for any reason.
We also prioritize storing an object as
MergeInterface*overTObject*when a class inherits both (MergeInterface::merge()was already prioritized, this does not change).