PWGHF: Add task to perform optimisation of preselections - #6612
Conversation
vkucera
left a comment
There was a problem hiding this comment.
Hi @fgrosa , on the first look, it seems fine to me. I have a general comment, though.
It is better to use the <object><attribute> (or <general><specific>) naming scheme, so that names of the same kind of objects start with same string and the different attributes follow.
This scheme makes names more readable, searchable and sortable.
For example, I think that
nCutsToTestCosp
nCutsToTestDecLen
nCutsToTestPtTrackMin
vecCutsCosp
vecCutsDecLen
vecCutsPtTrackMinis more readable (and sortable) than
nCospCutsToTest
nDecLenCutsToTest
nMinTrackPtCutsToTest
cospCutsVec
decLenCutsVec
minTrackPtCutsVecBtw, you already use that scheme for histogram names.
"hPromptVsPtD0ToPiK"
"hPromptVsPtJpsiToEE"
"hPromptVsPt2Prong"
Hi @vkucera, thanks for your feedback! Indeed I did not pay too much attention to the naming scheme, I should have now changed all the variables according to your suggestion! |
…p#6612) * Add task to perform optimisation of preselections * Add minimum track pT and histograms for inclusive 2 and 2 prongs
No description provided.