DCS config data format#6446
Merged
Merged
Conversation
Collaborator
|
@chiarazampolli thanks for the PR. Any reason why you are passing the dcsconfig by pointer in addConfigItem ? Why not just |
Collaborator
Author
|
Hi @aphecetche , No reason, and now I don't remember if it was like this since initially I did it differently. Yours is a good suggestion, I will change accordingly, thanks! Chiara |
using std::vector<char>
clang-format Fix trailing space
97df7af to
be42fe3
Compare
Collaborator
Author
|
Hello, macos errors does not seem related to my PR, unless i overlooked something. CI log is not present. @shahor02 , do you think this PR can be merged? Chiara |
shahor02
approved these changes
Jun 28, 2021
mcoquet642
pushed a commit
to mcoquet642/AliceO2
that referenced
this pull request
Jul 4, 2021
* typedef for DCS configuration using std::vector<char> * Change delimiter, improve print clang-format Fix trailing space * Update functions - do not use pointers * update copyright
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an example of data format to be used to fill the CCDB instance to store the calibration information to be used to configure detectors. Such object will be picked up by DCS, to be stored in Oracle and/or be used by the detectors (FEE or other).
See https://alice.its.cern.ch/jira/browse/O2-2341
E.g. for testing, run (compile first) the following: