Drop o2::byte - #6253
Conversation
|
Even better then this would be to simply replace o2::byte with just char. When do we expect the extra type safety to be actually useful? |
Replace it with C++17 std::byte. This does not endorse the actual idea behind std::byte usage, merely gets rid of an O2 specific type and header for it.
|
Concerning your second remark: what is the drawback of using std::byte ? |
|
@ironMann how would you like to proceed here? Shall we simply merge this and fix DataDistribution at the same time? |
|
@Barthelemy I missed you commented here. std::byte is a separate type from char, so there is casting involved everywhere this is not taken into account (e.g. when printing / formatting), which can catch some errors, but also might introduce a lot of boilerplate. As usual I guess it's a matter of tradeoffs. |
|
@kft Go ahead and merge if this is a simple rename. |
|
Ok, I did, could you tag DataDistribution with AliceO2Group/DataDistribution#94 included? |
Replace it with C++17 std::byte. This does not endorse the actual idea behind std::byte usage, merely gets rid of an O2 specific type and header for it.
Replace it with C++17 std::byte. This does not endorse the actual
idea behind std::byte usage, merely gets rid of an O2 specific type
and header for it.