[QC-585] Improve logs and metrics in Mergers#6227
Merged
Barthelemy merged 2 commits intoJun 21, 2021
Merged
Conversation
Collaborator
|
ok ! I will review today or Tuesday |
Collaborator
Author
|
@Barthelemy Which Tuesday? ;) |
Collaborator
|
lol, I am reviewing now ;) |
Barthelemy
previously approved these changes
May 26, 2021
1. Mergers will allow to specify the Monitoring backend. 2. More precise nomenclature in the logs and metrics. 3. Log when publishing objects 4. Initializing Monitoring moved to init() 5. Add "Mergers" tags to Monitoring metrics collector
92f66d0 to
efc84de
Compare
Collaborator
|
@ktf @TimoWilken Could you check why the fullCI test is failing ? |
knopers8
added a commit
to knopers8/AliceO2
that referenced
this pull request
Jun 28, 2021
* [QC-585] Improve logs and metrics in Mergers 1. Mergers will allow to specify the Monitoring backend. 2. More precise nomenclature in the logs and metrics. 3. Log when publishing objects 4. Initializing Monitoring moved to init() 5. Add "Mergers" tags to Monitoring metrics collector * trigger ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Barthelemy I decided not to count total number of entries inside histograms/trees for now, because it would require a larger effort. I would have to change MergeInterface (and synchronize the change in QC) and recursively browse objects which are not merged, but also copied (we copy the first object, the rest are merged), which would introduce some overhead. I am not sure if it's worth it.