PWGHF:Add Xicc analysis#6076
Closed
ginnocen wants to merge 23 commits into
Closed
Conversation
bec0368 to
2dac499
Compare
* more signal/backgroud histograms
d73b9a9 to
13b433b
Compare
vkucera
requested changes
May 25, 2021
Collaborator
vkucera
left a comment
There was a problem hiding this comment.
General comments:
- Use named numbers.
- Mention the name of the
enum. - Avoid
TaskName. - Follow naming conventions.
Please consider the following formatting changes to AliceO2Group#6076
added 10 commits
May 29, 2021 17:10
vkucera
reviewed
Jun 2, 2021
Comment on lines
+222
to
+225
| indexRec = RecoDecay::getMatchedMCRec(particlesMC, arrayDaughters, pdg::Code::kXiCCPlusPlus, array{+kProton, -kKPlus, +kPiPlus, +kPiPlus}, true, &sign, 3); | ||
| if (indexRec > -1) { | ||
| flag = 1 << DecayType::XiccToXicPi; | ||
| } |
Collaborator
There was a problem hiding this comment.
Shouldn't depth 2 be used?
Don't you need to also check Ξcc -> Ξc?
Collaborator
Author
There was a problem hiding this comment.
Yes, I am testing a version.
Comment on lines
+248
to
+249
| if (RecoDecay::isMatchedMCGen(particlesMC, XicCandMC, int(pdg::Code::kXiCPlus), array{+kProton, -kKPlus, +kPiPlus}, true, &sign)) { | ||
| flag = sign * (1 << DecayType::XiccToXicPi); |
Collaborator
There was a problem hiding this comment.
sign should correspond to the one returned by the first isMatchedMCGen and the second isMatchedMCGen should be called with acceptAntiParticles = false to guarantee the same sign of the Ξc daughter.
Collaborator
Author
There was a problem hiding this comment.
hi @vkucera I need some clarification on this point, this is why I haven't considered it yet. thanks.
Collaborator
Author
There was a problem hiding this comment.
Hi @vkucera, I understood the point (finally 👍 ). I will fix it accordingly
PWGHF: Update Xi_c task
Please consider the following formatting changes to AliceO2Group#6076
Contributor
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
Collaborator
|
Replace by #6843 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.