Adding parser for a set of data objects in consecutive memory pages - #585
Closed
matthiasrichter wants to merge 1 commit into
Closed
Adding parser for a set of data objects in consecutive memory pages#585matthiasrichter wants to merge 1 commit into
matthiasrichter wants to merge 1 commit into
Conversation
sawenzel
reviewed
Sep 28, 2017
Collaborator
There was a problem hiding this comment.
shouldn't types start with a capital letter?
Collaborator
Author
There was a problem hiding this comment.
true, but as it is it's more in the style of std::iterator
Collaborator
There was a problem hiding this comment.
Not sure about this. An iterator is defined via operators not via a standard name. In any case, such exceptions will make automatic code checks very hard (to be reliable) and probably we would need to introduce a way to annotate rule violations.
Memory pages have a fixed size and start with a page header. The parser provides transparent iteration through data objects and handles page boundaries.
matthiasrichter
force-pushed
the
dev-algorithm
branch
from
October 2, 2017 07:08
1bba59d to
9bb9ac8
Compare
Collaborator
Author
|
@sawenzel I have corrected the type names and pushed a new commit |
Collaborator
|
Error while checking build/o2/macos for 9bb9ac8: Full log here. |
Collaborator
Author
|
Concerning failing test on macos/xcode: The copy assignment operator has been implicitly deleted on purpose. I will check why the vector insert wants to make a copy and assign. Will take some time though, closing the PR for the moment. |
sawenzel
pushed a commit
that referenced
this pull request
Oct 23, 2017
…follow up #585) (#629) * Adding parser for a set of data objects in consecutive memory pages Memory pages have a fixed size and start with a page header. The parser provides transparent iteration through data objects and handles page boundaries. * Adding write functionality for parser iterator - bidirectional copy function - runtype check for the buffer const'ness - supporting iterator and const_iterator - fixing the assignment operator problem on xcode, now internally using pointer instead of reference. Using reference was resulting in making and assigning a copy.
mbroz84
pushed a commit
to mbroz84/AliceO2
that referenced
this pull request
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory pages have a fixed size and start with a page header. The parser
provides transparent iteration through data objects and handles page
boundaries.