Move DataHeader to use fmt::format - #5743
Merged
Merged
Conversation
ktf
requested review from
a team,
davidrohr,
shahor02 and
wiechula
as code owners
March 19, 2021 01:31
Member
Author
|
@mkrzewic @matthiasrichter @davidrohr @shahor02 this should simplify the formatting and the Descriptor class itself. We can probably get rid of asstd::string and use a std::string_view instead. |
Collaborator
|
fine for me if it works |
Member
Author
|
I need to patch QualityControl or do things in steps... :-/ |
ktf
force-pushed
the
use-fmt-data-header
branch
from
March 29, 2021 12:02
93a5286 to
6d5a1b5
Compare
Member
Author
This allows us to drop the templated Print policy from the DataHeader.h classes, hopefully simplifying the code. As a replacement for the various print methods one can use DataHeaderHelpers.h in conjuction with the various fmt / Logger.h methods.
ktf
force-pushed
the
use-fmt-data-header
branch
from
March 30, 2021 15:31
6d5a1b5 to
741cc17
Compare
Member
Author
|
Now that the associated QC is released (thanks @Barthelemy!), we can merge this. |
cortesep
pushed a commit
to cortesep/AliceO2
that referenced
this pull request
Jun 11, 2021
This allows us to drop the templated Print policy from the DataHeader.h classes, hopefully simplifying the code. As a replacement for the various print methods one can use DataHeaderHelpers.h in conjuction with the various fmt / Logger.h methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to remove some code from DataHeader.h, which is
included pretty much everywhere.