Skip to content

New conversion digits - raw#5533

Closed
cortesep wants to merge 23 commits into
AliceO2Group:devfrom
cortesep:dev_zdcawrw
Closed

New conversion digits - raw#5533
cortesep wants to merge 23 commits into
AliceO2Group:devfrom
cortesep:dev_zdcawrw

Conversation

@cortesep
Copy link
Copy Markdown
Contributor

@cortesep cortesep commented Feb 23, 2021

WIP - from new digits format to raw

@cortesep cortesep requested review from a team, sawenzel and shahor02 as code owners February 23, 2021 10:39
Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cortesep looks good but you have to apply clang-format to all you commits git clang-format HEAD~8
If this should not be merged soon, please put [WIP] in the beginning of the title, so that it does not run tests in vain.

@cortesep cortesep changed the title Dev zdcawrw WIP Dev zdcawrw Feb 23, 2021
@cortesep cortesep changed the title WIP Dev zdcawrw WIP New conversion digits - raw Feb 23, 2021
@shahor02 shahor02 changed the title WIP New conversion digits - raw [WIP] New conversion digits - raw Feb 23, 2021
@shahor02
Copy link
Copy Markdown
Collaborator

@cortesep is this ready for review / tests?

@cortesep cortesep changed the title [WIP] New conversion digits - raw New conversion digits - raw Feb 25, 2021
@cortesep
Copy link
Copy Markdown
Contributor Author

@cortesep is this ready for review / tests?

Hi Ruben. Yes. I removed the WIP.

Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cortesep

For this PR specifically: could you please change the mixture of root types (UInt...) to basic or std::.. types.
I have a comment on

void Digits2Raw::insertLastBunch(int ibc, uint32_t orbit)
: I don't see where is used, probably can be removed.

@ktf ktf removed the request for review from a team March 2, 2021 08:25
@shahor02
Copy link
Copy Markdown
Collaborator

shahor02 commented Mar 6, 2021

Closing as was overridden by already merged #5585

@shahor02 shahor02 closed this Mar 6, 2021
@cortesep cortesep deleted the dev_zdcawrw branch June 24, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants