[EMCAL-682,EMCAL-660,EMCAL-650] Discarding empty links in raw payload#5517
Conversation
mfasDa
left a comment
There was a problem hiding this comment.
Though I suggested to move the indexing functions to the Mapper I now see it is better to move them to the Geometry, because in the Geometry they are stand-alone members, while in the Mapper they induce a new unnecessary dependence on the Geometry.
There was a problem hiding this comment.
I think this function should better go to the o2::emcal::Geometry class. It is only using classes from there, so that would be the place to go, while in the Mapper this introduces an unnecessary dependency on Geometry
There was a problem hiding this comment.
Move to o2::emcal::Geometry
There was a problem hiding this comment.
Is this OK to squash/merge?
There was a problem hiding this comment.
I think it is fine to squash/merge
There were empty links with IDs 21 and 39, and two links connected to LEDmon only with IDs 22 and 36. These links has been discarded. So they will not be processed.
Also we adapted link assignment in simulation to link assignment in production FLPs according to [EMCAL-660].
RCUTrailer encoding has been added according to [EMCAL-650].