Introduced 2d arrays in Variant#5132
Merged
Merged
Conversation
Member
aalkin
commented
Jan 7, 2021
- added matrix struct
- added parsers for matrix into/from boost ptree and string representation
- extended Variant to use matrix<int/float/double>
- added matrix data memmbers handling for serialization
- updated configurableObjects.cxx example
* added matrix<T> struct * added parsers for matrix into/from boost ptree and string representation * extended Variant to use matrix<int/float/double> * added matrix data memmbers handling for serialization * updated configurableObjects.cxx example
Member
|
I would prefer a name like |
Member
Author
No reason, just the first name that came to mind. I'll rename to |
ktf
previously approved these changes
Jan 8, 2021
ktf
reviewed
Jan 11, 2021
| } else if constexpr (is_base_of_template<std::vector, T>::value) { | ||
| return extractVector<typename T::value_type>(mStore->store().get_child(key)); | ||
| } else if constexpr (is_base_of_template<o2::framework::Array2D, T>::value) { | ||
| return extractMatrix<typename T::element_t>(mStore->store().get_child(key)); |
Member
There was a problem hiding this comment.
should probably be extractArray2D, fine for now.
ktf
reviewed
Jan 11, 2021
Comment on lines
+123
to
+125
| V == VariantType::MatrixInt || | ||
| V == VariantType::MatrixFloat || | ||
| V == VariantType::MatrixDouble) { |
Member
There was a problem hiding this comment.
Should probably be Array2DInt, etc.
Member
|
Merging this, however please make sure you consistently use Array2D everywhere. |
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.