Skip to content

Small update for the converter#5002

Merged
jgrosseo merged 4 commits into
AliceO2Group:devfrom
nburmaso:dev
Dec 6, 2020
Merged

Small update for the converter#5002
jgrosseo merged 4 commits into
AliceO2Group:devfrom
nburmaso:dev

Conversation

@nburmaso
Copy link
Copy Markdown
Contributor

@nburmaso nburmaso commented Dec 4, 2020

*configurable TFNumber
*collision time wrt to the beginning of collision BC

@nburmaso nburmaso requested a review from a team as a code owner December 4, 2020 13:33
}

// collision timestamp in ns wrt to the beginning of collision BC
tsTimeStamp = tsTimeStamp - std::lround(tsTimeStamp / o2::constants::lhc::LHCBunchSpacingNS) * o2::constants::lhc::LHCBunchSpacingNS;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this considering if the most probably BC which is filled into GlobalBC is off by 2 BCs ?

Copy link
Copy Markdown
Contributor Author

@nburmaso nburmaso Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think I should correct this to
tsTimeStamp = globalBC * o2::constants::lhc::LHCBunchSpacingNS - tsTimeStamp
The code currently does not account for a filling scheme, so most probable BC == meanBC

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did Ruben already put the function in the vertex? To get the most probably BC moved by the filling scheme? I think it should be on his side, not yours. Then you just take that value.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, it is not ready yet. At least I do not see the function in PrimaryVertex.h or in Vertex.h (if it even should be in these classes).

@jgrosseo jgrosseo merged commit 1bb0a22 into AliceO2Group:dev Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants