Skip to content

minor fix #4911

Merged
sawenzel merged 2 commits into
AliceO2Group:devfrom
AllaMaevskaya:raw
Nov 24, 2020
Merged

minor fix #4911
sawenzel merged 2 commits into
AliceO2Group:devfrom
AllaMaevskaya:raw

Conversation

@AllaMaevskaya
Copy link
Copy Markdown
Contributor

from Artur for FLP test. They need it urgent

mslupeck
mslupeck previously approved these changes Nov 24, 2020
Copy link
Copy Markdown
Collaborator

@mslupeck mslupeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me.

@sawenzel sawenzel merged commit f2db480 into AliceO2Group:dev Nov 24, 2020
sawenzel added a commit to sawenzel/AliceO2 that referenced this pull request Nov 27, 2020
This reverts commit f2db480.

This commit broke the unit test Detectors/CTF/test/test_ctf_io_ft0.cxx
which unfortunately was not spotted/executed in the CI.
@sawenzel
Copy link
Copy Markdown
Collaborator

I need to revert this. Somehow the unit tests were not executed and we didn't spot failures induced by this commit.

@shahor02
Copy link
Copy Markdown
Collaborator

Hi @AllaMaevskaya
This PR breaks the FT0 CTF IO test, so it will be reverted. Could you please check and make sure that

cd ~/alice/sw/BUILD/O2-latest/O2
./stage/tests/o2-test-ctf-ft0

runs w/o problems

sawenzel added a commit that referenced this pull request Nov 27, 2020
This reverts commit f2db480.

This commit broke the unit test Detectors/CTF/test/test_ctf_io_ft0.cxx
which unfortunately was not spotted/executed in the CI.
@AllaMaevskaya AllaMaevskaya deleted the raw branch January 7, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants