Skip to content

Fix test fetching headers #4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 2 commits into from
Oct 28, 2020
Merged

Fix test fetching headers #4699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d253d69
fix TestFetchingHeaders
Barthelemy Oct 28, 2020
d5ed4b3
format
Barthelemy Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions CCDB/test/testCcdbApi.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,16 +421,24 @@ BOOST_AUTO_TEST_CASE(TestHeaderParsing)

BOOST_AUTO_TEST_CASE(TestFetchingHeaders, *utf::precondition(if_reachable()))
{
// first store the object
string objectPath = basePath + "objectETag";
test_fixture f;
TH1F h1("objectETag", "objectETag", 100, 0, 99);
f.api.storeAsTFile(&h1, objectPath, f.metadata);

// then get the headers
std::string etag;
std::vector<std::string> headers;
std::vector<std::string> pfns;
auto updated = CcdbApi::getCCDBEntryHeaders("http://ccdb-test.cern.ch:8080/TOF/LHCphase/1567080816927", etag, headers);
string path = objectPath + "/" + std::to_string(getCurrentTimestamp());
auto updated = CcdbApi::getCCDBEntryHeaders("http://ccdb-test.cern.ch:8080/" + path, etag, headers);

@sawenzel sawenzel Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. so I was wrong and we checked to supposedly existing object. This is now as it should be! Thanks.

BOOST_CHECK_EQUAL(updated, true);
BOOST_REQUIRE(headers.size() != 0);
CcdbApi::parseCCDBHeaders(headers, pfns, etag);
BOOST_REQUIRE(etag != "");
BOOST_REQUIRE(pfns.size());
updated = CcdbApi::getCCDBEntryHeaders("http://ccdb-test.cern.ch:8080/TOF/LHCphase/1567080816927", etag, headers);
updated = CcdbApi::getCCDBEntryHeaders("http://ccdb-test.cern.ch:8080/" + path, etag, headers);
BOOST_CHECK_EQUAL(updated, false);
}

Expand Down