Fix: libfmt does not allow non-void* ptrs, triggers assertion#4694
Merged
Conversation
jgrosseo
approved these changes
Oct 28, 2020
Collaborator
|
@davidrohr Thanks! The assertion came where? I didn't see this in my tests. How can one find it? |
Collaborator
Author
|
Depends on the libfmt version I guess
|
Collaborator
Author
|
@jgrosseo : for reference: It is forbidden in the libfmt spec. I actually filed a feature request with them because it annoyed me but it was rejected. https://github.com/fmtlib/fmt#1248 |
tklemenz
pushed a commit
to tklemenz/AliceO2
that referenced
this pull request
Nov 12, 2020
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.