Adapt DataInputDirector to the new AO2D file format, which includes a subdirectory TF_%d per time frame#4573
Merged
Conversation
…e. Each TF is saved in a sub folder TF_%d. Each subfolder contains the same trees.
Collaborator
|
test_Framework_test_DataInputDirector fails, is this due to the missing adaptation in the writer? |
Collaborator
Author
|
Not really, but I propose to disable the test for the moment and I will have to write new tests for reader/writer. |
…ly updated later.
Collaborator
|
The conversion trains are running (96-98). Most likely we can merge this tonight. |
Collaborator
|
Had passed tests before I resolved merge conflict which was just changing a comment. Merging now. |
tklemenz
pushed a commit
to tklemenz/AliceO2
that referenced
this pull request
Nov 12, 2020
… subdirectory TF_%d per time frame (AliceO2Group#4573) * This allows to save table data of several Time Frames (TF) in one file. Each TF is saved in a sub folder TF_%d. Each subfolder contains the same trees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes have been tested with simple cases. Further testing is ongoing.