Skip to content

PrimaryGenerator that can propagate mother/daughter indices#4361

Merged
sawenzel merged 2 commits into
AliceO2Group:devfrom
preghenella:rdev-parents-daughters
Sep 24, 2020
Merged

PrimaryGenerator that can propagate mother/daughter indices#4361
sawenzel merged 2 commits into
AliceO2Group:devfrom
preghenella:rdev-parents-daughters

Conversation

@preghenella
Copy link
Copy Markdown
Collaborator

This PR allows mother and daughter indices from MC generators to be propagated up to the PrimaryGenerator and eventually can be propagated into the Stack.

@preghenella preghenella marked this pull request as draft September 16, 2020 11:31
@amorsch
Copy link
Copy Markdown
Collaborator

amorsch commented Sep 16, 2020

fStack->PushTrack(doTracking, mother1, pdgid, px, py, pz,
e, vx, vy, vz, tof, polx, poly, polz, proc, ntr,
weight, status, parent);
weight, status, mother1);
->
fStack->PushTrack(doTracking, mother1, pdgid, px, py, pz,
e, vx, vy, vz, tof, polx, poly, polz, proc, ntr,
weight, status, parent);
weight, status, mother2);

@preghenella
Copy link
Copy Markdown
Collaborator Author

hi @amorsch ,

yes, this is what will have to be done.
I wanted to have this in incremental steps.
I will push a second commit with that change.

@sawenzel , please do not squash when merging. I'd like to keep the two commits separated.

@preghenella preghenella marked this pull request as ready for review September 16, 2020 14:46
@preghenella
Copy link
Copy Markdown
Collaborator Author

the Check PR with clang-format / build (pull_request_target) fails

fatal: ambiguous argument '.github/workflows/code-formatting.yml': unknown revision or path not in the working tree.
1422
Use '--' to separate paths from revisions, like this:

which does not seem to be related to this PR

@preghenella
Copy link
Copy Markdown
Collaborator Author

@amorsch
please check the second commit which passes the secondparent in the stack.
9f00f66

@preghenella
Copy link
Copy Markdown
Collaborator Author

@sawenzel can this be merged?
I do not see where the problems in the checks are, look not related to the PR

@sawenzel sawenzel merged commit cc19587 into AliceO2Group:dev Sep 24, 2020
@preghenella preghenella deleted the rdev-parents-daughters branch September 30, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants