Skip to content

DPL: open ipc socket in a tmp directory (O2-1512)#4043

Merged
ktf merged 1 commit into
AliceO2Group:devfrom
ktf:tmpdir
Jul 28, 2020
Merged

DPL: open ipc socket in a tmp directory (O2-1512)#4043
ktf merged 1 commit into
AliceO2Group:devfrom
ktf:tmpdir

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Jul 27, 2020

This has better chances to succeed (e.g. no AFS) and will avoid polluting the
pwd.

@ktf ktf requested a review from a team as a code owner July 27, 2020 13:42
@ktf ktf changed the title DPL: open ipc socket in a tmp directory DPL: open ipc socket in a tmp directory (O2-1512) Jul 27, 2020
@ktf
DPL: open ipc socket in a tmp directory
5015b3f 
This has better chances to succeed (e.g. no AFS) and will avoid polluting the
pwd.
@ktf ktf merged commit 0edd93c into AliceO2Group:dev Jul 28, 2020
@ktf ktf deleted the tmpdir branch July 28, 2020 08:23
@shahor02
Copy link
Copy Markdown
Collaborator

shahor02 commented Jul 30, 2020

@ktf : rebuilding fresh dev on Rome server

Linux version 4.18.0-147.8.1.el8_1.x86_64 (mockbuild@kbuilder.bsys.centos.org) (gcc version 8.3.1 20190507 (Red Hat 8.3.1-4) (GCC)) #1 SMP Thu Apr 9 13:49:54 UTC 2020

I get:

[ 22%] Linking CXX shared library ../../stage/lib64/libO2Framework.so
CMakeFiles/O2lib-Framework.dir/src/ChannelSpecHelpers.cxx.o: In function `(anonymous namespace)::getTmpFolder()':
/home/ruben/alice/sw/SOURCES/O2/v1.2.0/0/Framework/Core/src/ChannelSpecHelpers.cxx:27: undefined reference to `std::filesystem::temp_directory_path[abi:cxx11]()'
collect2: error: ld returned 1 exit status
gmake[2]: *** [Framework/Core/CMakeFiles/O2lib-Framework.dir/build.make:1544: stage/lib64/libO2Framework.so] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:8980: Framework/Core/CMakeFiles/O2lib-Framework.dir/all] Error 2

Isn't std::filesystem not fully portable extention?

@ktf
Copy link
Copy Markdown
Member Author

ktf commented Jul 30, 2020

Looks like -lstdc++fs is missing. Can you try adding it to the CMakeList.txt for Framework/Core?

Are you building with GCC 7.3 or 8.x? In principle 8.x should add it directly while 7.3 should require #include <experimental/filesystem> so it should fallback to boost.

arakotoz pushed a commit to arakotoz/AliceO2 that referenced this pull request Sep 26, 2020
@ktf @arakotoz
DPL: open ipc socket in a tmp directory (AliceO2Group#4043)
421dfbd 
This has better chances to succeed (e.g. no AFS) and will avoid polluting the
pwd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ktf @shahor02