Make sure to print an error if data is lost while terminating DPL raw proxy - #3811
Merged
Merged
Conversation
Amending PR AliceO2Group#3801. Checking for the requested change of device state before dispatching messages might silently drop data. Have to ensure that message are always dispatched, and if the sending does not succeed an error message is printed. Only after that the pending device state change is checked and can break the loop.
matthiasrichter
force-pushed
the
amend-pr3801
branch
from
June 15, 2020 13:43
957e75d to
2e46494
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amending PR #3801. Checking for the requested change of device state before
dispatching messages might silently drop data.
Have to ensure that message are always dispatched, and if the sending does not
succeed an error message is printed. Only after that the pending device state
change is checked and can break the loop.