Skip to content

Publishing MCHTracking headers for Track and TrackParam#3648

Merged
aphecetche merged 1 commit into
AliceO2Group:devfrom
rpezzi:MCHRootDict
Jun 2, 2020
Merged

Publishing MCHTracking headers for Track and TrackParam#3648
aphecetche merged 1 commit into
AliceO2Group:devfrom
rpezzi:MCHRootDict

Conversation

@rpezzi
Copy link
Copy Markdown
Collaborator

@rpezzi rpezzi commented May 24, 2020

@pillot , this is to use MCH tracking classes in root macros.

  • headers and src files split in separated directories.
  • o2_target_root_dictionary section for MCHTracking added to CMakeLists.txt

OK to proceed with this?

@rpezzi
Copy link
Copy Markdown
Collaborator Author

rpezzi commented May 27, 2020

@pillot , @aphecetche , this is a lightweight dictionary with Track and TrackParam. Cluster.h moved to include/MCHTracking so that Track.h/cxx finds it. It may be possible to include with "../../src/Cluster.h" to avoid exposing Cluster.

@rpezzi rpezzi changed the title Create MCHTracking root dictionary Publishing MCHTracking headers for Track and TrackParam May 27, 2020
@rpezzi rpezzi marked this pull request as ready for review May 27, 2020 19:00
@rpezzi rpezzi requested a review from aphecetche as a code owner May 27, 2020 19:00
aphecetche
aphecetche requested changes May 27, 2020
View reviewed changes
Comment thread Detectors/MUON/MCH/Tracking/CMakeLists.txt Outdated
Comment thread Detectors/MUON/MCH/Tracking/src/MCHTrackingLinkDef.h Outdated
@rpezzi rpezzi force-pushed the MCHRootDict branch 2 times, most recently from ef20d2f to 50e0677 Compare May 27, 2020 20:27
@rpezzi rpezzi requested a review from aphecetche May 27, 2020 20:29
aphecetche
aphecetche previously approved these changes May 27, 2020
View reviewed changes
@rpezzi
Copy link
Copy Markdown
Collaborator Author

rpezzi commented May 28, 2020

While GPU Check seems unrelated to this PR, checkcode is failing unable to find Cluster.h and TrackParam.h at the new locations. Any idea?

[ 28%] Building CXX object Detectors/MUON/MCH/Tracking/CMakeFiles/O2lib-MCHTracking.dir/src/Cluster.cxx.o
[ 28%] Built target O2exe-analysistutorial-new-collections
/mnt/mesos/sandbox/sandbox/sw/SOURCES/O2/build_o2checkcode_o2/0/Detectors/MUON/MCH/Tracking/src/Cluster.cxx:16:10: fatal error: MCHTracking/Cluster.h: No such file or directory
 #include "MCHTracking/Cluster.h"
          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [Detectors/MUON/MCH/Tracking/CMakeFiles/O2lib-MCHTracking.dir/src/Cluster.cxx.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
[ 28%] Building CXX object Detectors/MUON/MCH/Tracking/CMakeFiles/O2lib-MCHTracking.dir/src/TrackParam.cxx.o
/mnt/mesos/sandbox/sandbox/sw/SOURCES/O2/build_o2checkcode_o2/0/Detectors/MUON/MCH/Tracking/src/TrackParam.cxx:16:10: fatal error: MCHTracking/TrackParam.h: No such file or directory
 #include "MCHTracking/TrackParam.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [Detectors/MUON/MCH/Tracking/CMakeFiles/O2lib-MCHTracking.dir/src/TrackParam.cxx.o] Error 1
gmake[1]: *** [Detectors/MUON/MCH/Tracking/CMakeFiles/O2lib-MCHTracking.dir/all] Error 2

@aphecetche aphecetche mentioned this pull request May 29, 2020
Merged
5 tasks
@rpezzi
Copy link
Copy Markdown
Collaborator Author

rpezzi commented May 31, 2020

@ktf , this PR just moves tree files to the include directory. Can you please check why o2checkcode is unable to find files at the new location?

@rpezzi rpezzi mentioned this pull request Jun 1, 2020
Merged
@aphecetche aphecetche merged commit 48b1383 into AliceO2Group:dev Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aphecetche aphecetche aphecetche approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rpezzi @aphecetche