[FV0] Added getter and utility functions to fv0::Geometry to be used …#3463
Merged
Conversation
Member
|
@jotwinow @AllaMaevskaya could you please review and eventually approve? Thanks. |
Contributor
|
Look fine. I agree. |
Member
|
@AllaMaevskaya @jotwinow notice that there was a "add review" button at the top of the PR which you should use to review them and eventually approva. In the future we will automate the merging process once all test pass and an approval is there. For now I merged it by hand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in Digitization
This is meant to introduce a set of functions to facilitate splitting the signal from a single cell in ring 5 to two readout channels in the Digitizer.