Fix of MClabels#2801
Merged
Merged
Conversation
Collaborator
|
This needs clang-formatting. @ktf: The CI failure in o2checkcode/o2 seems to come from an interaction with another unmerged PR #2777 (from which build artefacts are picked up here - I can see this from the message that dictionaries for o2::phos::Digit exist twice). Would it be possible to clean the build area to come back to a normal state? |
Member
|
I did the cleanup, but we probably need to close / fix @ginnocen PR to avoid reappearing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned by Michael Knichel in the PDP plenary talk, there were no MC labels produced by FDD. This should fix the problem. The embedding works as well, as far as I understand.