Using the end-of-stream condition in the RootTreeReader/Writer tests#2785
Merged
Merged
Conversation
The EOS condition allows to drop the logic for triggering the workflow termination. Also make sure not to publish any more data after the EOS condition has been sent. The publisher of the RootTreeReader test was constantly pumping data into the workflow. This can conflict with the device termination and produces the error which sometimes makes the test fail Failed sending on socket foo.push, reason: Interrupted system call This is the actual cause for the problem tried to be fixed in d474376.
d0147a5 to
8fb294f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EOS condition allows to drop the logic for triggering the workflow
termination.
Also make sure not to publish any more data after the EOS condition has
been sent. The publisher of the RootTreeReader test was constantly pumping
data into the workflow. This can conflict with the device termination and
produces the error which sometimes makes the test fail
Failed sending on socket foo.push, reason: Interrupted system call
This is the actual cause for the problem tried to be fixed in d474376.