Skip to content

Fixes in Doxygen documentation: - #2725

Merged
sawenzel merged 5 commits into
AliceO2Group:devfrom
ihrivnac:doxygen-update-2
Dec 20, 2019
Merged

Fixes in Doxygen documentation:#2725
sawenzel merged 5 commits into
AliceO2Group:devfrom
ihrivnac:doxygen-update-2

Conversation

@ihrivnac

Copy link
Copy Markdown
Contributor
  • Restored the main page and fixed links to internal pages
  • Fixed links to sub pages
  • Updated DoxygenInstructions.md
  • Updated instructions in .travis.yaml and moved the filtering instructions
    (now obsolete) in commented lines in doc/scripts/filter_for_doxygen.sh

@ihrivnac
ihrivnac requested review from a team, sawenzel and shahor02 as code owners December 18, 2019 11:54
@ihrivnac

Copy link
Copy Markdown
Contributor Author

@ktf, @MichaelLettrich ,
Could you, please, take a look in the mods in travis which fails now? Thank you,

@ktf

ktf commented Dec 18, 2019

Copy link
Copy Markdown
Member

Does it work if you revert the change you did at:

https://github.com/AliceO2Group/AliceO2/pull/2725/files#diff-354f30a63fb0907d4ad57269548329e3L68-L77

?

- Restored the main page and fixed links to internal pages
- Fixed links to sub pages
- Updated DoxygenInstructions.md
- Updated instructions in .travis.yaml and moved the filtering instructions
  (now obsolete) in commented lines in doc/scripts/filter_for_doxygen.sh
- Disabled  Doxygen keywords rendering on GitHub
- Use Markdown syntax in the lists
- Fixes in Doxygen pages tag names
@ihrivnac

Copy link
Copy Markdown
Contributor Author

@sawenzel , @Barthelemy , @davidrohr ,
Could someone review this PR? Thank you,

sawenzel
sawenzel previously approved these changes Dec 20, 2019

@sawenzel sawenzel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

Comment thread .travis.yml Outdated
- Updated doxygen filter for code higlighting
@ihrivnac

Copy link
Copy Markdown
Contributor Author

@ktf ,
I removed the commented lines; is there a way to see the generated documentation before the PR is accepted? Thank you.

@ktf

ktf commented Dec 20, 2019

Copy link
Copy Markdown
Member

I am afraid, not.

@sawenzel

Copy link
Copy Markdown
Collaborator

Merging. We can re-iterate from here.

@sawenzel
sawenzel merged commit a89550a into AliceO2Group:dev Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants