Skip to content

Remove old classes of CCDB #2428

Merged
sawenzel merged 7 commits into
AliceO2Group:devfrom
Barthelemy:remove-oldies-ccdb
Oct 2, 2019
Merged

Remove old classes of CCDB #2428
sawenzel merged 7 commits into
AliceO2Group:devfrom
Barthelemy:remove-oldies-ccdb

Conversation

@Barthelemy
Copy link
Copy Markdown
Collaborator

does not compile yet

@Barthelemy Barthelemy requested review from a team, davidrohr and shahor02 as code owners September 23, 2019 15:15
@Barthelemy
Copy link
Copy Markdown
Collaborator Author

@wiechula I am trying to remove the old classes from the CCDB package. I see that you used o2::ccdb::Manager in the past and I have tried to replace it with o2::ccdb::BasicCCDBManager developed by @sawenzel . There is still the test testTPCCCDBInterface that is simply commented out.

@sawenzel I am not sure how to proceed with testTPCCCDBInterface. BasicCCDBManager does not allow for writing/setting data, right ? and any ways the snaphsot system does not allow to store data , does it ?

@wiechula
Copy link
Copy Markdown
Collaborator

@Barthelemy , fine with me. We can adopt the test later. I guess that to some extend I'll need to rework the CDB access anyway. If I understand correctly, the TObjWrapper is not needed any longer. I this correct?
From my side, just go ahead.

@Barthelemy
Copy link
Copy Markdown
Collaborator Author

@wiechula The TObjWrapper is not needed anymore. Ideally I would like to adapt your test, but I need some help from @sawenzel . If it is not doable quickly, I will indeed merge.
Thanks

@sawenzel
Copy link
Copy Markdown
Collaborator

Could you rebase this branch? For some reason there is a conflict. I will try to take a look at the unit test today to complete this PR.

@Barthelemy
Copy link
Copy Markdown
Collaborator Author

That is weird, it was already rebased. I have forced push without the merge commit and it seems to be ok like that.

@Barthelemy
Copy link
Copy Markdown
Collaborator Author

@sawenzel it is ok now

@Barthelemy Barthelemy changed the title [WIP] Remove old classes of CCDB Remove old classes of CCDB Oct 1, 2019
@Barthelemy
Copy link
Copy Markdown
Collaborator Author

@sawenzel it is passing all builds.

@sawenzel sawenzel merged commit 7296873 into AliceO2Group:dev Oct 2, 2019
knopers8 pushed a commit to knopers8/AliceO2 that referenced this pull request Oct 23, 2019
* Remove old classes of CCDB

* Changes for TPC (TestTPCCDBInterface disabled)

* add doxygen
carlos-soncco pushed a commit to carlos-soncco/AliceO2 that referenced this pull request Oct 28, 2019
* Remove old classes of CCDB

* Changes for TPC (TestTPCCDBInterface disabled)

* add doxygen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants