Skip to content

DPL: add generic walker for DataDescriptorMatcher #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Jul 17, 2019
Merged

DPL: add generic walker for DataDescriptorMatcher #2220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 110 additions & 0 deletions Framework/Core/include/Framework/DataMatcherWalker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
// Copyright CERN and copyright holders of ALICE O2. This software is
// distributed under the terms of the GNU General Public License v3 (GPL
// Version 3), copied verbatim in the file "COPYING".
//
// See http://alice-o2.web.cern.ch/license for full licensing information.
//
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.
#ifndef O2_FRAMEWORK_DATAMATCHERWALKER_H_
#define O2_FRAMEWORK_DATAMATCHERWALKER_H_

#include "Framework/DataDescriptorMatcher.h"
#include "Framework/VariantHelpers.h"

namespace o2::framework::data_matcher
{

struct EdgeActions {
struct EnterNode {
DataDescriptorMatcher const* node;
};
struct ExitNode {
DataDescriptorMatcher const* node;
};
struct EnterLeft {
};
struct ExitLeft {
};
struct EnterRight {
};
struct ExitRight {
};
};

enum ChildAction : int {
VisitNone = 0,
VisitLeft = 1,
VisitRight = 2,
VisitBoth = 3
};

using EdgeAction = std::variant<EdgeActions::EnterNode, EdgeActions::ExitNode>;

/// Helper class which holds methods which are useful
/// to navigate a DataDescriptorMatcher hierarchy
struct DataMatcherWalker {

// Deep-first algorithm
// @a top is the toplevel node in the tree.
// @a edgeWalker is a visitor for an EdgeAction
// @a leafWalker is a visitor for the DataDescriptorMatcher node
template <typename EDGEWALKER, typename LEAFWALKER>
static void walk(DataDescriptorMatcher const& top,
EDGEWALKER edgeWalker,
LEAFWALKER leafWalker)
{
std::vector<EdgeAction> matchers;
matchers.push_back(EdgeActions::EnterNode{ &top });

while (matchers.empty() == false) {
EdgeAction action = matchers.back();
matchers.pop_back();
ChildAction childrenVisitor = std::visit(overloaded{
[&matchers, &edgeWalker](EdgeActions::EnterNode action) {
matchers.push_back(EdgeActions::ExitNode{ action.node });
return edgeWalker(action);
},
[&edgeWalker](EdgeActions::ExitNode action) {
edgeWalker(action);
return ChildAction::VisitNone;
} },
action);

if (childrenVisitor & ChildAction::VisitRight) {
auto node = std::visit([](auto action) { return action.node; }, action);

std::visit(overloaded{
[&matchers](std::unique_ptr<DataDescriptorMatcher> const& matcher) {
matchers.push_back(EdgeActions::EnterNode{ matcher.get() });
},
[edgeWalker, leafWalker](auto const& leaf) {
edgeWalker(EdgeActions::EnterRight{});
leafWalker(leaf);
edgeWalker(EdgeActions::ExitRight{});
} },
node->getRight());
}

if (childrenVisitor & ChildAction::VisitLeft) {
auto node = std::visit([](auto action) { return action.node; }, action);

std::visit(overloaded{
[&matchers](std::unique_ptr<DataDescriptorMatcher> const& matcher) {
matchers.push_back(EdgeActions::EnterNode{ matcher.get() });
},
[edgeWalker, leafWalker](auto const& leaf) {
edgeWalker(EdgeActions::EnterLeft{});
leafWalker(leaf);
edgeWalker(EdgeActions::ExitLeft{});
} },
node->getLeft());
}
}
}
};

} // namespace o2::framework::data_matcher

#endif // O2_FRAMEWORK_DATAMATCHERWALKER_H_
45 changes: 27 additions & 18 deletions Framework/Core/src/DataDescriptorMatcher.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@

#include "Framework/CompilerBuiltins.h"
#include "Framework/DataDescriptorMatcher.h"
#include "Framework/DataMatcherWalker.h"
#include "Framework/DataProcessingHeader.h"
#include "Framework/VariantHelpers.h"
#include <iostream>

namespace o2
Expand Down Expand Up @@ -413,25 +415,32 @@ bool DataDescriptorMatcher::operator==(DataDescriptorMatcher const& other) const

std::ostream& operator<<(std::ostream& os, DataDescriptorMatcher const& matcher)
{
auto printer = [&os](decltype(&matcher.mLeft) v) -> void {
if (auto left = std::get_if<std::unique_ptr<DataDescriptorMatcher>>(v)) {
os << **left;
} else if (auto originMatcher = std::get_if<OriginValueMatcher>(v)) {
os << "origin:" << *originMatcher;
} else if (auto descriptionMatcher = std::get_if<DescriptionValueMatcher>(v)) {
os << "description:" << *descriptionMatcher;
} else if (auto subSpecMatcher = std::get_if<SubSpecificationTypeValueMatcher>(v)) {
os << "subSpec:" << *subSpecMatcher;
} else if (auto startTimeMatcher = std::get_if<StartTimeValueMatcher>(v)) {
os << "startTime:" << *startTimeMatcher;
}
auto edgeWalker = overloaded{
[&os](EdgeActions::EnterNode action) {
os << "(" << action.node->mOp;
if (action.node->mOp == DataDescriptorMatcher::Op::Just) {
return ChildAction::VisitLeft;
}
return ChildAction::VisitBoth;
},
[&os](EdgeActions::EnterLeft) { os << " "; },
[&os](EdgeActions::ExitLeft) { os << " "; },
[&os](EdgeActions::EnterRight) { os << " "; },
[&os](EdgeActions::ExitRight) { os << " "; },
[&os](EdgeActions::ExitNode) { os << ")"; },
[&os](auto) {}
};

os << "(" << matcher.mOp << " ";
printer(&matcher.mLeft);
os << " ";
printer(&matcher.mRight);
os << ")";
auto leafWalker = overloaded{
[&os](OriginValueMatcher const& origin) { os << "origin:" << origin; },
[&os](DescriptionValueMatcher const& description) { os << "description:" << description; },
[&os](SubSpecificationTypeValueMatcher const& subSpec) { os << "subSpec:" << subSpec; },
[&os](StartTimeValueMatcher const& startTime) { os << "startTime:" << startTime; },
[&os](ConstantValueMatcher const& constant) {},
[&os](auto t) { os << "not implemented " << typeid(decltype(t)).name(); }
};
DataMatcherWalker::walk(matcher,
edgeWalker,
leafWalker);

return os;
}
Expand Down