Skip to content

[WIP] Bugfix after CMake modernization #2172, run workflow tests again - #2213

Merged
matthiasrichter merged 1 commit into
AliceO2Group:devfrom
matthiasrichter:fix-cmake-run-workflow-tests
Jul 17, 2019
Merged

[WIP] Bugfix after CMake modernization #2172, run workflow tests again#2213
matthiasrichter merged 1 commit into
AliceO2Group:devfrom
matthiasrichter:fix-cmake-run-workflow-tests

Conversation

@matthiasrichter

Copy link
Copy Markdown
Collaborator

The workflow test programs are no boost unit tests, flag NO_BOOST_TEST was not
set in #2172. The inserted -- was causing the test programs to ignore all
command line args, and without option --run they all dumped the configuration
instead of running the test.

set(A_COMMAND_LINE_ARGS "--" ${A_COMMAND_LINE_ARGS})

@matthiasrichter
matthiasrichter force-pushed the fix-cmake-run-workflow-tests branch from b88dc47 to 67d214b Compare July 16, 2019 08:43
@matthiasrichter

Copy link
Copy Markdown
Collaborator Author

Need to think what to do with two failing test

100 - test_Framework_test_CustomGUIGL (Failed)
101 - test_Framework_test_CustomGUISokol (Failed)

The problem is that the X11 environment is not complete in the CI. @ktf what do you think?

[57133]: [METRIC] matcher_variables/0,1 null 1563268624174 hostname=alientest06.ceError 65544: X11: The DISPLAY environment variable is missing
[57133]: o2-test-framework-CustomGUISokol: /builddir/build/BUILD/glfw-3.2.1/src/window.c:579: glfwGetFramebufferSize: Assertion `window != ((void *)0)' failed.

@matthiasrichter
matthiasrichter force-pushed the fix-cmake-run-workflow-tests branch from 67d214b to b2b6c24 Compare July 16, 2019 11:29
@matthiasrichter matthiasrichter changed the title Bugfix after CMake modernization #2172, run workflow tests again [WIP] Bugfix after CMake modernization #2172, run workflow tests again Jul 16, 2019
…s again

The workflow test programs are no boost unit tests, flag NO_BOOST_TEST was not
set in AliceO2Group#2172. The inserted '--' was causing the test programs to ignore all
command line args, and without option --run they all dumped the configuration
instead of running the test.

Disable unit test `DanglingInputs`, Processor `D` is failing with the following error
    [ERROR] Unable to relay part.
    [WARN] Incoming data is already obsolete, not relaying.
We don't know when it stopped working because the workflow unit test have been
accidentally inactive at some point. But it should have been after 62d7284.
@matthiasrichter
matthiasrichter force-pushed the fix-cmake-run-workflow-tests branch from 146ae06 to 347453f Compare July 16, 2019 14:06
@matthiasrichter

Copy link
Copy Markdown
Collaborator Author

The following unit test need more investigation and are disabled for now

  • DanglingInputs
  • BoostSerializedProcessing
  • CustomGUIGL
  • CustomGUISokol

@matthiasrichter
matthiasrichter merged commit a124a62 into AliceO2Group:dev Jul 17, 2019
@matthiasrichter
matthiasrichter deleted the fix-cmake-run-workflow-tests branch July 17, 2019 07:24
MichaelLettrich pushed a commit that referenced this pull request Jul 24, 2019
The workflow test programs aren't boost unit tests, flag `NO_BOOST_TEST` was not
set in #2172. The inserted '--' was causing the test programs to ignore all
command line args, and without option --run they all dumped the configuration
instead of running the test.

The following unit test need more investigation and are disabled for now
- DanglingInputs
- BoostSerializedProcessing
- CustomGUIGL
- CustomGUISokol

Unit test `DanglingInputs`, Processor `D` is failing with the following error
    [ERROR] Unable to relay part.
    [WARN] Incoming data is already obsolete, not relaying.
We don't know when it stopped working because the workflow unit test have been
accidentally inactive at some point. But it should have been after 62d7284.

The GUI unit test fail because of X11 environment setup of the CI machine.
knopers8 pushed a commit to knopers8/AliceO2 that referenced this pull request Oct 23, 2019
…s again (AliceO2Group#2213)

The workflow test programs aren't boost unit tests, flag `NO_BOOST_TEST` was not
set in AliceO2Group#2172. The inserted '--' was causing the test programs to ignore all
command line args, and without option --run they all dumped the configuration
instead of running the test.

The following unit test need more investigation and are disabled for now
- DanglingInputs
- BoostSerializedProcessing
- CustomGUIGL
- CustomGUISokol

Unit test `DanglingInputs`, Processor `D` is failing with the following error
    [ERROR] Unable to relay part.
    [WARN] Incoming data is already obsolete, not relaying.
We don't know when it stopped working because the workflow unit test have been
accidentally inactive at some point. But it should have been after 62d7284.

The GUI unit test fail because of X11 environment setup of the CI machine.
carlos-soncco pushed a commit to carlos-soncco/AliceO2 that referenced this pull request Oct 28, 2019
…s again (AliceO2Group#2213)

The workflow test programs aren't boost unit tests, flag `NO_BOOST_TEST` was not
set in AliceO2Group#2172. The inserted '--' was causing the test programs to ignore all
command line args, and without option --run they all dumped the configuration
instead of running the test.

The following unit test need more investigation and are disabled for now
- DanglingInputs
- BoostSerializedProcessing
- CustomGUIGL
- CustomGUISokol

Unit test `DanglingInputs`, Processor `D` is failing with the following error
    [ERROR] Unable to relay part.
    [WARN] Incoming data is already obsolete, not relaying.
We don't know when it stopped working because the workflow unit test have been
accidentally inactive at some point. But it should have been after 62d7284.

The GUI unit test fail because of X11 environment setup of the CI machine.
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Apr 15, 2023
* Simplify the structure of the macro

* Adapt checkBCrange macro to new split files

* Add EvSel BC in the CEFP output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant