Fix missing fmt dependency#2184
Merged
Merged
Conversation
MichaelLettrich
pushed a commit
that referenced
this pull request
Jul 24, 2019
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Oct 23, 2019
carlos-soncco
pushed a commit
to carlos-soncco/AliceO2
that referenced
this pull request
Oct 28, 2019
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Apr 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ktf @aphecetche : fmt is now an alidist dependency, and CMake finds fmt, but fmt::fmt was not added to the Logger. Consequently, it was not used, and even breaking systems which have fmt system-wide, because the header is available, but it is not linked.