Moving MCLabels from digits to global stack#2133
Conversation
|
Weird. There are merge conflicts. Can you please solve them? |
|
Indeed weird. Trying to understand what is going on... |
|
There are compilation failures (in ROOT macros). Can you please take a look and fix them? |
|
Merge conflicts need to be addressed. |
|
@peressounko @sawenzel : Any chance we merge this tomorrow, since this is rather larger, and applying clang-format on the weekend will create merge conflicts. It passes the tests now at least. |
| << pos.Y() << ", " << pos.Z() << "), time" << time << ", qdep =" << qdep << std::endl; | ||
| mHits->emplace_back(trackID, detID, pos, time, qdep); | ||
| // register hit creation with MCStack | ||
| static_cast<o2::data::Stack*>(fMC->GetStack())->addHit(GetDetId()); |
There was a problem hiding this comment.
this has to stay. it is required to notify someone that a track left a hit in CPV.
There was a problem hiding this comment.
Sandro, David, I do not plan to touch CPV yet - I will return this lost line.
Presently I implemented filling of MCLabels for PHOS, but I did not try it with DPL framework yet. With old-fashined approach with DigitiserTask I still fighting with problem
[INFO] CREATING BRANCH PHOSDigitMCTruth
[FATAL] No dictionary found for o2::dataformats::MCTruthContainero2::phos::MCLabel
Probably it is better to postpone merging till I will manage to run digitization with DPL.
Or it is easier to merge now as is and continue with new clang formatting? What do you suggest? Thanks, Dmitri
|
@davidrohr : Yes we can merge it before the weekend |
|
I'll leave it up to you, but if it compiles and doesn't break anything, we can as well merge tomorrow. Then you can continue in a new PR. |
|
OK, then if you agree, lets merge as is. Dmitri |
|
ok, @sawenzel : when you have no comments any more, can you merge it? |
|
|
||
| // Register output containers | ||
| mgr->RegisterAny("PHOSDigit", mDigitsArray, kTRUE); | ||
| mgr->RegisterAny("PHOSDigitMCTruth", mLabels, kTRUE); |
There was a problem hiding this comment.
As communicated privately, this IO mechanism is deprecated since we do no longer use the FairTask mechanism.
Rather IO is typically performed by a dedicated DPL writer process. We can adjust this in another round.
|
@peressounko : Please don't push more commits to this PR before the weekend. The CI needs quite some time to run and it could delay merging. |
| #pragma link C++ class o2::phos::Detector+; | ||
| #pragma link C++ class o2::phos::GeometryParams+; | ||
| #pragma link C++ class o2::base::DetImpl<o2::phos::Detector>+; | ||
| #pragma link C++ class o2::phos::MCLabel+; |
There was a problem hiding this comment.
just adding the label is not enough; you also need to add the specialization ...MCLabelContainer<o2::phos::MCLabel>+ since that is the actual type written to disc.
* Moving MCLabels from digits to global stack * Adding MCLabel branch to tree
* Moving MCLabels from digits to global stack * Adding MCLabel branch to tree
Co-authored-by: Dmitri Peresunko <Dmitri.Peresunko@cern.ch>
No description provided.