DPL: streamline DataAllocator::make - #1970
Merged
Merged
Conversation
Member
Author
|
@matthiasrichter this is how I would streamline the This is WIP because there is something which needs to change in order to be able to use |
matthiasrichter
left a comment
Collaborator
There was a problem hiding this comment.
This looks very nice, I have nothing to add for the moment.
matthiasrichter
force-pushed
the
streamline-make
branch
from
June 27, 2019 07:44
4231fbd to
1b0587b
Compare
Collaborator
Member
Author
|
As discussed privately, there is an issue with references, IIRC. We should resolve that before merging this. |
Collaborator
|
I think we also see it in the CI, will try to have a look |
Member
Author
|
yes, exactly. |
5 tasks
matthiasrichter
force-pushed
the
streamline-make
branch
from
July 11, 2019 22:25
1b0587b to
2b1191e
Compare
matthiasrichter
left a comment
Collaborator
There was a problem hiding this comment.
Using decltype(auto) allows to deduce from the expression whether to return reference or value.
This supports the current case for the arrow::ipc::RecordBatchWriter and will enable to return unique_ptr or similar objects by move in the future.
Using `decltype(auto)` to deduce the return type from the expression. It will be lvalue reference for the framework-owned objects. Instances of local variables like shared_ptr will be returned by value/move/return value optimization. Not all branches of allocator API function `make` will return references to objects owned by an allocator context. E.g. shared_ptr objects are returned by return value optimization. Currently there is one use case for the arrow schema, but similar arguments apply if unique_ptr with custom dealloator will be used in the future to control the scope of the objects in the code and allow immediate sending once an object goes out of scope
matthiasrichter
force-pushed
the
streamline-make
branch
from
July 12, 2019 12:12
3a64ff0 to
6b82ff3
Compare
3 tasks
Member
Author
|
Look good to me. Thanks. I am merging this. |
MichaelLettrich
pushed a commit
that referenced
this pull request
Jul 24, 2019
This uses C++ if constexpr to simplify and unify the `DataAllocator::make` logic, hopefully resulting in more readable code. Notice how it uses `decltype(auto)` to deduce the return type from the expression. The original commit 6b82ff3 has an exhaustive description of why this is needed.
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Oct 23, 2019
This uses C++ if constexpr to simplify and unify the `DataAllocator::make` logic, hopefully resulting in more readable code. Notice how it uses `decltype(auto)` to deduce the return type from the expression. The original commit 6b82ff3 has an exhaustive description of why this is needed.
carlos-soncco
pushed a commit
to carlos-soncco/AliceO2
that referenced
this pull request
Oct 28, 2019
This uses C++ if constexpr to simplify and unify the `DataAllocator::make` logic, hopefully resulting in more readable code. Notice how it uses `decltype(auto)` to deduce the return type from the expression. The original commit 6b82ff3 has an exhaustive description of why this is needed.
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Apr 15, 2023
…eO2Group#1970) * Added gamma trigger * Added gamma, allows qa to only consider jets in EMCAL Added max spectra --------- Co-authored-by: Gijs van Weelden <g.van.weelden@nikhef.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.