Doxygen documentation update (O2-525)#1813
Conversation
|
Hi @ihrivnac, thank you very much for your PR! I have two questions:
Thanks for your efforts! |
There was a problem hiding this comment.
This was my temporary change to make doxygen generation faster, now reverted
4f30cab to
0f0a5dc
Compare
|
Hi @dberzano , The new generated documentation is available at: The PR does not solve the problem of Doxygen tags being mixed up with Markdown; the problem is that Markdown processing precedes Doxygen and so if we comment out the Doxygen keywords for Markdown, they are not seen by Doxygen. A reasonable compromise is to have the top README.md page free of Doxygen keywords, but use them in the bottom pages. Otherwise we would need to think about implementing some filtering procedure which would be triggered from CMake when generating documentation. But I don't think that it is worth the effort. |
|
Do we really need ‘Module XXX’ rather than simply XXX?
…--
Ciao,
Giulio
On 22 Mar 2019, 09:54 +0100, ihrivnac ***@***.***>, wrote:
Hi @dberzano ,
The new generated documentation is available at:
http://ivana.home.cern.ch/ivana/o2_html3/index.html
The PR does not solve the problem of Doxygen tags being mixed up with Markdown; the problem is that Markdown processing precedes Doxygen and so if we comment out the Doxygen keywords for Markdown, they are not seen by Doxygen.
A reasonable compromise is to have the top README.md page free of Doxygen keywords, but use them in the bottom pages. Otherwise we would need to think about implementing some filtering procedure which would be triggered from CMake when generating documentation. But I don't think that it is worth the effort.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Not necessarily, but with using these we make get clearer documentation when referring to this page from other place: eg. see more in Module XXX, instead of see more in XXX. |
|
Isn’t it just a matter of typing “module” outside the link?
…--
Ciao,
Giulio
On 22 Mar 2019, 10:39 +0100, ihrivnac ***@***.***>, wrote:
Not necessarily, but with using these we make get clearer documentation when referring to this page from other place: eg. see more in Module XXX, instead of see more in XXX.
And the second reason for this that it makes non-structured bottom pages (if someones add a new page without the Doxygen keywords) better apparent in the list on the left.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Yes for the first reason; but not for the second one. Actually in the re-generated documentation there is a newly added page "O2 Framework Foundation" which pollutes the global "namespace". Once the "Module " is removed this would get hidden in the list of the top directories. |
0f0a5dc to
2042673
Compare
|
Thanks Ivana for the updated doc. The markdown thingy is still bothering me. There is one more problem : the code samples. They are not colorized in doxygen (and the language hint of the markdown does appear as well in the doxygen generated page). In fact, the issue is a bit more general for me : I much prefer the rendering of GitHub markdown than the Doxygen one : I find it easier to read. So, am I challenging the need for Doxygen altogether ? Well, maybe ... |
|
Personally I think Doxygen should not pollute the markdown files in a way that makes them badly render on Github. People are much more likely to go to github first and then to doxygen and in any case while we have no ways to post-process the markdown pages when rendered by github, we can do so for doxygen ones.
…On 22 Mar 2019, 12:50 +0100, ihrivnac ***@***.***>, wrote:
This is because you are using Markdown syntax for code highlighting; when replacing
-```c++
+\code{.cpp}
you get the code highlighted in Doxygen documentation:
To get both, we would need again to implement some filtering to get rid off the other tool keywords in the representation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I fully agree with @ktf. Code must render properly here on GitHub using standard Markdown.
|
2042673 to
39d468f
Compare
|
Yes, Doxygen can render ok Markdown but Markdown does not understand Doxygen keywords which we need to create a structure of documentation pages. So we need to make these keywords invisible for Markdown, but then filter-out the Markdown comments to get the keywords seen by Doxygen, There is now updated the README in Utilities, see: and its source: The filtering command, which should be applied for processing with doxygen should be: If you find this way ok, I will take a look how to introduce the command above in the Doxygen filter. Or if you know how to do it, let me know. |
|
I added the filtering in the Doxygen configuration file; this uses a new script filter_for_doxygen.sh added in doc/scripts. If this approach is ok for you, I will update the other README files as done for Utilities, plus the documentation page. |
- Added README.md to all top directories - Added \page definitions in all existing .md files
- Removed update for investigation of coexistence Markdown/Doxygen pages - Changed Package to Module in the documentation pages
CLASS_DIAGRAMS set back to YES
|
Discussion seems to have stalled here. We should address this in the next WP3 meeting (@dberzano). |
|
@ihrivnac as discussed at the last WP3: this one is good to be merged, except for one very minor thing. We now have: <!-- For Doxygen
\page refUtilities Module 'Utilities'
---- end Doxygen -->We believe we can have it much shorter: <!-- doxy
\page refUtilities Module 'Utilities'
/doxy -->This means that the script can simply do: sed -e 's|<!-- doxy||; s|/doxy -->||' "$1"With this one modification we're good to go. I took care of it so I am merging it. Thanks @ihrivnac for making it happen! |


Introduced structuring of documentation pages: