Skip to content

CCDB api : Prevent whitespaces in file name#1774

Merged
ktf merged 3 commits into
AliceO2Group:devfrom
Barthelemy:feature-prevent-whitespaces-in-CCDBapi
Mar 27, 2019
Merged

CCDB api : Prevent whitespaces in file name#1774
ktf merged 3 commits into
AliceO2Group:devfrom
Barthelemy:feature-prevent-whitespaces-in-CCDBapi

Conversation

@Barthelemy

Copy link
Copy Markdown
Collaborator

The commit also introduces a StringUtils.h with trimming functions.

The commit also introduces a StringUtils.h with trimming functions.
@sawenzel

sawenzel commented Mar 8, 2019

Copy link
Copy Markdown
Collaborator

the new clang format seems to want to do funny things.

@Barthelemy

Copy link
Copy Markdown
Collaborator Author

Yes, it seems to be confused with the lambdas ?

@Barthelemy

Copy link
Copy Markdown
Collaborator Author

There are actually a few correct changes
Let me rerun clang format on my side.

@Barthelemy

Copy link
Copy Markdown
Collaborator Author

Maybe this will do the trick

@Barthelemy

Copy link
Copy Markdown
Collaborator Author

There is still a change that clang-format in travis would like to do but I think that it is wrong. Also the build failure is probably wrong.
@ktf ?

@ktf

ktf commented Mar 8, 2019

Copy link
Copy Markdown
Member

I agree clang-format goes bananas. For the error I wonder if it's a side effect of the new clang on picking up the system tools...@dberzano can you remind me where to find the log?

@ktf ktf merged commit db51a56 into AliceO2Group:dev Mar 27, 2019
@ktf

ktf commented Mar 27, 2019

Copy link
Copy Markdown
Member

I am merging this since it seems to be green now (apart from the usual issues). Any reason why boost::algorithm::trim was not used?

@Barthelemy

Copy link
Copy Markdown
Collaborator Author

The extraction of the trimming functions to their own file was just a side effect of using the trimming in a new place. I presume that we could use boost::trim here.

@Barthelemy

Copy link
Copy Markdown
Collaborator Author

When you will rewrite the CCDB api (merge with the DPL one) you can fix it ;)

@ktf

ktf commented Mar 27, 2019

Copy link
Copy Markdown
Member

Okok... ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants