Refactor/shared lookuptable - #15667
Open
spulawsk wants to merge 3 commits into
Open
Conversation
added 3 commits
August 6, 2026 22:36
Extract the PM lookup table construction from the FT0 Digitizer into a reusable PMLookupTable class. The lookup is initialized only once and reused by the Digitizer, avoiding repeated LUT parsing and making the mapping available for other FT0 components. No functional changes are intended.
spulawsk
marked this pull request as ready for review
August 7, 2026 09:07
spulawsk
requested review from
afurs,
andreasmolander,
jotwinow and
sahilupadhyaya92
as code owners
August 7, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the FT0 PM lookup table construction from the Digitizer into a dedicated PMLookupTable class.
The new class encapsulates:
the mapping between FT0 channel IDs and PM hashes,
the PM A/C side information,
one-time initialization of the lookup from SingleLUT.
The Digitizer has been refactored to use this shared lookup instead of maintaining its own internal static lookup table.
Motivation
The PM lookup logic was previously implemented directly inside Digitizer::storeBC(), making it difficult to reuse from other FT0 components.
Moving this functionality into a dedicated class:
centralizes the lookup construction,
avoids duplicated code,
provides a common interface that can be reused by future reconstruction, trigger and QA code,
improves maintainability by separating lookup initialization from the digitization algorithm.
Functional impact
This PR is intended to be a pure refactoring.
No changes to the digitization or trigger logic are intended. The PM lookup construction has simply been moved into a reusable component while preserving the existing mapping.